Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @SuppressWarnings("removal") to not fail the build with -Werror for some JDKs #11923

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 18, 2024

Description

We are currently building on JDK-21 but with JDK-17 fe the build fails with:

/.../OpenSearch/test/framework/src/main/java/org/opensearch/mockito/plugin/PriviledgedMockMaker.java:101: warning: removal] at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74) [gradle-worker.jar:?] AccessController in java.security has been deprecated and marked for removal                                                                                                         

AccessController.doPrivileged((PrivilegedAction<Void>) () -> { 

error: warnings found and -Werror specified                

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Compatibility status:

Checks if related components are compatible with change 9f34e74

Incompatible components

Incompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❕ Gradle check result for c17acba: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.index.reindex.UpdateByQueryBasicTests.testMultipleSources
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (904c9a9) 71.44% compared to head (9f34e74) 71.35%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11923      +/-   ##
============================================
- Coverage     71.44%   71.35%   -0.10%     
+ Complexity    59397    59386      -11     
============================================
  Files          4923     4923              
  Lines        279178   279178              
  Branches      40581    40581              
============================================
- Hits         199470   199214     -256     
- Misses        63064    63439     +375     
+ Partials      16644    16525     -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for 9f34e74: SUCCESS

@kotwanikunal kotwanikunal merged commit 411b279 into opensearch-project:main Jan 18, 2024
@reta reta added the backport 2.x Backport to 2.x branch label Jan 18, 2024
reta pushed a commit that referenced this pull request Jan 18, 2024
…or some JDKs (#11923) (#11930)

(cherry picked from commit 411b279)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants