Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow Flight Server bootstrap logic #16962

Merged
merged 38 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7441bd0
Arrow Flight Server bootstrap logic
rishabhmaurya Jan 6, 2025
a032158
interim changes - integration with Auxiliary Transport
rishabhmaurya Jan 14, 2025
4979201
changes to use grpc-netty-shaded
rishabhmaurya Jan 16, 2025
2fad521
Update javadoc
rishabhmaurya Jan 16, 2025
904f18f
fix the shaded dependencies
rishabhmaurya Jan 20, 2025
e0fa147
Move arrow-flight-rpc from module to plugin
rishabhmaurya Jan 20, 2025
b913504
remove unnecessary imports
rishabhmaurya Jan 20, 2025
7647d8d
rebase fixes
rishabhmaurya Jan 20, 2025
28a4fb6
Fix permissions and other runtime issues
rishabhmaurya Jan 21, 2025
0c6f9fe
Remove StreamManagerWrapper and Node.java changes from PR
rishabhmaurya Jan 21, 2025
1282aba
Fix permissions for test
rishabhmaurya Jan 21, 2025
5b2f66f
remove testGetFlightClientLocationExecutionError as thread interrupti…
rishabhmaurya Jan 21, 2025
70ee8c2
Fix the issue with single node ClientManager
rishabhmaurya Jan 23, 2025
3b93ce2
Fix flight server integ test on unix machine
rishabhmaurya Jan 24, 2025
e1cc6a6
suppress JSM removal warning
rishabhmaurya Jan 24, 2025
dd613ca
Fix security policy and FlightClientManagerTests
rishabhmaurya Jan 25, 2025
90e8599
remove StreamManagerWrapper from the PR
rishabhmaurya Jan 26, 2025
af550a1
Set multi-release in manifest while shadowing arrow-memory-shaded
rishabhmaurya Jan 27, 2025
19ada07
Disable jacocoReport for shaded projects
rishabhmaurya Jan 27, 2025
f4e86c6
Remove multi version classes from arrow-memory-shaded
rishabhmaurya Jan 28, 2025
c7bac06
Address the PR comments
rishabhmaurya Jan 28, 2025
1cae780
Move the arrow-memory-shaded and flight within flight-rpc plugin
rishabhmaurya Jan 28, 2025
649eaea
Move the arrow-memory-shaded and flight within flight-rpc plugin
rishabhmaurya Jan 28, 2025
21cec56
Detach SPI from Apache Arrow (not needed at the moment), drop all sha…
reta Jan 29, 2025
c3f143b
Rebase and other minor refactoring
rishabhmaurya Feb 8, 2025
546931e
Address PR comments - majorly move away from grpc-netty-shaded
rishabhmaurya Feb 10, 2025
0fcb852
remove arrow flight, client from codecov as the package is non opense…
rishabhmaurya Feb 10, 2025
1a02a08
change compileOnly to implementation dep for arrow-spi
rishabhmaurya Feb 10, 2025
9252558
Rebase from main and fixes related to netty version bump
rishabhmaurya Feb 11, 2025
16886a1
Simplify cloning and overriding logic for FlightServer and FlightClient
rishabhmaurya Feb 13, 2025
96624dc
Only clone FlightClient::Builder class
reta Feb 14, 2025
67762f0
Only clone FlightServer::Builder class
reta Feb 18, 2025
1e5f920
Update min supported version to 3.0.0
rishabhmaurya Feb 18, 2025
3628c84
Fix java security permission issue
rishabhmaurya Feb 18, 2025
9087f0c
Address PR comments
rishabhmaurya Feb 19, 2025
fda5c60
Fix netty system properties
rishabhmaurya Feb 20, 2025
70b7c01
Move flight service and other components of flight-rpc-plugin behind …
rishabhmaurya Feb 20, 2025
ddd47fa
remove system property value set numDirectArenas
rishabhmaurya Feb 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-3.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Added pull-based Ingestion (APIs, for ingestion source, a Kafka plugin, and IngestionEngine that pulls data from the ingestion source) ([#16958](https://github.com/opensearch-project/OpenSearch/pull/16958))
- Added ConfigurationUtils to core for the ease of configuration parsing [#17223](https://github.com/opensearch-project/OpenSearch/pull/17223)
- Add execution_hint to cardinality aggregator request (#[17312](https://github.com/opensearch-project/OpenSearch/pull/17312))
- Arrow Flight RPC plugin with Flight server bootstrap logic and client for internode communication ([#16962](https://github.com/opensearch-project/OpenSearch/pull/16962))

### Dependencies
- Update Apache Lucene to 10.1.0 ([#16366](https://github.com/opensearch-project/OpenSearch/pull/16366))
Expand Down
1 change: 1 addition & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ codecov:
ignore:
- "test"
- "benchmarks"
- "plugins/arrow-flight-rpc/**/org/apache/arrow/flight/**"

coverage:
precision: 2
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ opentelemetry = "1.46.0"
opentelemetrysemconv = "1.29.0-alpha"

# arrow dependencies
arrow = "17.0.0"
arrow = "18.1.0"
flatbuffers = "2.0.0"

[libraries]
Expand Down
70 changes: 1 addition & 69 deletions libs/arrow-spi/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,79 +10,11 @@
*/

testingConventions.enabled = false

dependencies {
api project(':libs:opensearch-core')
api "org.apache.arrow:arrow-vector:${versions.arrow}"
api "org.apache.arrow:arrow-format:${versions.arrow}"
api "org.apache.arrow:arrow-memory-core:${versions.arrow}"
runtimeOnly "org.apache.arrow:arrow-memory-netty-buffer-patch:${versions.arrow}"
runtimeOnly "org.apache.arrow:arrow-memory-netty:${versions.arrow}"
runtimeOnly "io.netty:netty-buffer:${versions.netty}"
runtimeOnly "io.netty:netty-common:${versions.netty}"

runtimeOnly "com.google.flatbuffers:flatbuffers-java:${versions.flatbuffers}"
runtimeOnly "org.slf4j:slf4j-api:${versions.slf4j}"
runtimeOnly "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
api "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}"

implementation "commons-codec:commons-codec:${versions.commonscodec}"
}

tasks.named('forbiddenApisMain').configure {
replaceSignatureFiles 'jdk-signatures'
}

tasks.named('thirdPartyAudit').configure {
ignoreMissingClasses(
// Logging frameworks
'org.apache.commons.logging.Log',
'org.apache.commons.logging.LogFactory',
'org.apache.log4j.Level',
'org.apache.log4j.Logger',
'org.slf4j.impl.StaticLoggerBinder',
'org.slf4j.impl.StaticMDCBinder',
'org.slf4j.impl.StaticMarkerBinder',

// Reactor BlockHound
'reactor.blockhound.BlockHound$Builder',
'reactor.blockhound.integration.BlockHoundIntegration'
)

ignoreViolations(
"io.netty.util.internal.PlatformDependent0",
"io.netty.util.internal.PlatformDependent0\$1",
"io.netty.util.internal.PlatformDependent0\$2",
"io.netty.util.internal.PlatformDependent0\$3",
"io.netty.util.internal.PlatformDependent0\$4",
"io.netty.util.internal.PlatformDependent0\$6",
"io.netty.util.internal.shaded.org.jctools.queues.BaseLinkedQueueConsumerNodeRef",
"io.netty.util.internal.shaded.org.jctools.queues.BaseLinkedQueueProducerNodeRef",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueColdProducerFields",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueConsumerFields",
"io.netty.util.internal.shaded.org.jctools.queues.BaseMpscLinkedArrayQueueProducerFields",
"io.netty.util.internal.shaded.org.jctools.queues.LinkedQueueNode",
"io.netty.util.internal.shaded.org.jctools.queues.MpmcArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpmcArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.MpscArrayQueueProducerLimitField",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeLongArrayAccess",
"io.netty.util.internal.shaded.org.jctools.util.UnsafeRefArrayAccess",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueConsumerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerIndexField",
"io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerLimitField",
"org.apache.arrow.memory.ArrowBuf",
"org.apache.arrow.memory.util.ByteFunctionHelpers",
"org.apache.arrow.memory.util.MemoryUtil",
"org.apache.arrow.memory.util.MemoryUtil\$1",
"org.apache.arrow.memory.util.hash.MurmurHasher",
"org.apache.arrow.memory.util.hash.SimpleHasher",
"org.apache.arrow.vector.BaseFixedWidthVector",
"org.apache.arrow.vector.BitVectorHelper",
"org.apache.arrow.vector.Decimal256Vector",
"org.apache.arrow.vector.DecimalVector",
"org.apache.arrow.vector.util.DecimalUtility",
"org.apache.arrow.vector.util.VectorAppender"
)
}
1 change: 0 additions & 1 deletion libs/arrow-spi/licenses/arrow-format-17.0.0.jar.sha1

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion libs/arrow-spi/licenses/arrow-vector-17.0.0.jar.sha1

This file was deleted.

8 changes: 0 additions & 8 deletions libs/arrow-spi/licenses/jackson-databind-LICENSE.txt

This file was deleted.

20 changes: 0 additions & 20 deletions libs/arrow-spi/licenses/jackson-databind-NOTICE.txt

This file was deleted.

Loading
Loading