Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Propagate includes and excludes from fetchSourceContex… #17112

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Gankris96
Copy link
Contributor

…t to FieldsVisitor

Description

Backport of #17080

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
PR is part of #2377
as part of the Derived source feature for k-NN.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Gankris96
Copy link
Contributor Author

@jed326; @jmazanec15 Backport of #17080

Copy link
Contributor

❕ Gradle check result for ff51295: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (fa08247) to head (ff51295).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...n/java/org/opensearch/search/fetch/FetchPhase.java 40.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17112      +/-   ##
============================================
+ Coverage     71.91%   72.01%   +0.10%     
- Complexity    65716    65792      +76     
============================================
  Files          5322     5322              
  Lines        306214   306232      +18     
  Branches      44655    44663       +8     
============================================
+ Hits         220206   220538     +332     
+ Misses        67630    67258     -372     
- Partials      18378    18436      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit fe58b0d into opensearch-project:2.x Jan 24, 2025
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants