fix simultaneously creating a snapshot and updating the repository can potentially trigger an infinite loop

[kkewwei]

Description

Related Issues

Resolves #17531

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 2a17f65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 5b2dd4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d766eb3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 2757776: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for f234048: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 7957cdb: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (dcad6b8) to head (27de151).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ch/repositories/blobstore/BlobStoreRepository.java	20.00%	2 Missing and 2 partials ⚠️
.../org/opensearch/repositories/FilterRepository.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17532      +/-   ##
============================================
+ Coverage     72.46%   72.48%   +0.01%     
+ Complexity    65757    65746      -11     
============================================
  Files          5311     5311              
  Lines        305001   305017      +16     
  Branches      44230    44232       +2     
============================================
+ Hits         221022   221094      +72     
+ Misses        65932    65777     -155     
- Partials      18047    18146      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kkewwei]

UNSTABLE

❕ Gradle check result for 7957cdb: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation ##14293

[bugmakerrrrrr]

I don't want to change the API, I'm wondering if we can retry in SnapshotsService, that is, re-call the createSnapshot method when startRepository != currentRepository

[kkewwei]

It seems that there is no elegant way to exit unless the executeConsistentStateUpdate is modified.

[bugmakerrrrrr]

I think you can use the onFailure to do retry in SnapshotService. When this repo is closed, not to re-call the executeConsistentStateUpdate and invoke the onFailure.

[github-actions]

❌ Gradle check result for b054499: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

❌ Gradle check result for b054499: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

S3RemoteStoreIT.testPeerRecoveryWithLowActivityTimeout #16145

[github-actions]

❌ Gradle check result for b3e8d32: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d0ae308: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 27de151: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❌ Gradle check result for 53a2e8c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?