Added changes to enable full file cache stats #17538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayanksharma27
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
bugmakerrrrrr,
jainankitk and
linuxpi
as code owners
|
❌ Gradle check result for da0dcc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
gbbafna
reviewed
Mar 10, 2025
server/src/main/java/org/opensearch/index/store/remote/filecache/FullFileCacheStats.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/index/store/remote/filecache/FullFileCacheStatsCollector.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/WritableWarmIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/WritableWarmIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/WritableWarmIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/filecache/FileCache.java
Outdated
Show resolved
Hide resolved
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
from
8abab62 to
2373609
Compare
|
❌ Gradle check result for 2373609: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rayshrey
reviewed
May 22, 2025
server/src/main/java/org/opensearch/index/store/remote/filecache/AggregateFileCacheStats.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/filecache/FileCache.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/filecache/FileCacheStats.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opensearch/index/store/remote/utils/cache/stats/IRefCountedCacheStats.java
Show resolved
Hide resolved
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
from
2373609 to
a76bf30
Compare
|
❌ Gradle check result for a76bf30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
from
a76bf30 to
f506cf3
Compare
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
2 times, most recently
from
416b10f to
ea56708
Compare
|
❌ Gradle check result for ea56708: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 72f8ba0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
from
72f8ba0 to
cd3221b
Compare
|
❌ Gradle check result for cd3221b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
rayshrey
reviewed
May 23, 2025
server/src/main/java/org/opensearch/index/store/remote/filecache/AggregateFileCacheStats.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/WritableWarmIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27
force-pushed
the
smynk-tiering-FullfileCacheStats
branch
from
cd3221b to
141d05c
Compare
gbbafna
approved these changes
May 23, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Storage Project Board
This was referenced May 28, 2025
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
Signed-off-by: Mayank Sharma <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
Signed-off-by: Mayank Sharma <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
Signed-off-by: Mayank Sharma <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Mayank Sharma <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Mayank Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #17479.
Meta Issue #13149
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.