Fix flakiness of RemoteRestoreSnapshotIT.testClusterManagerFailoverDuringSnapshotCreation #17589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
|
❌ Gradle check result for 31ed84c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ringSnapshotCreation Signed-off-by: Igonin <[email protected]> Co-authored-by: Benny Goerzig <[email protected]> Co-authored-by: Karsten Schnitter <[email protected]> Co-authored-by: Kai Sternad <[email protected]>
|
❕ Gradle check result for ec11e44: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17589 +/- ##
============================================
+ Coverage 72.27% 72.49% +0.21%
- Complexity 65611 65809 +198
============================================
Files 5311 5311
Lines 304942 304946 +4
Branches 44225 44226 +1
============================================
+ Hits 220407 221077 +670
+ Misses 66448 65778 -670
- Partials 18087 18091 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beanuwave
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19 and
reta
as code owners
beanuwave
requested review from
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
cwperks
approved these changes
Mar 19, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Storage Project Board
|
Thank you for fixing this test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test case org.opensearch.remotestore.RemoteRestoreSnapshotIT.testClusterManagerFailoverDuringSnapshotCreation is flaky.
The test allows snapshot creation to fail and, if it does, verifies that the repository does not include its ID. In this scenario, the snapshot is not created - its snapshot info will be
null- which leads to an NPE.Related Issues
Resolves #14324
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.