[Pull-based Ingestion] Support custom Kafka consumer configs #17594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunbharadwaj
changed the title
|
❌ Gradle check result for adfeb83: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
varunbharadwaj
force-pushed
the
vb/customconsumerconfig
branch
from
adfeb83 to
f0bfd05
Compare
yupeng9
reviewed
Mar 15, 2025
plugins/ingestion-kafka/src/main/java/org/opensearch/plugin/kafka/KafkaSourceConfig.java
Outdated
Show resolved
Hide resolved
varunbharadwaj
force-pushed
the
vb/customconsumerconfig
branch
3 times, most recently
from
2de5380 to
5c15eb5
Compare
varunbharadwaj
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17594 +/- ##
============================================
+ Coverage 72.48% 72.51% +0.03%
- Complexity 65771 65809 +38
============================================
Files 5311 5311
Lines 304973 304977 +4
Branches 44229 44228 -1
============================================
+ Hits 221045 221142 +97
+ Misses 65830 65729 -101
- Partials 18098 18106 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varunbharadwaj
force-pushed
the
vb/customconsumerconfig
branch
from
5c15eb5 to
ec10ff1
Compare
|
LGTM |
|
❌ Gradle check result for ec10ff1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/customconsumerconfig
branch
from
ec10ff1 to
e51c75f
Compare
|
❕ Gradle check result for e51c75f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This was referenced Mar 18, 2025
andrross
approved these changes
Mar 18, 2025
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Varun Bharadwaj <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom Kafka configurations passed during index creation. The user will be allowed to pass in any Kafka consumer property in the ingestion source 'params' map, which will be passed to the Kafka consumer during initialization.
Related Issues
Follow-up for #16927
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.