Skip to content

[Pull-based Ingestion] Introduce ingestion management APIs #17631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

[Pull-based Ingestion] Introduce ingestion management APIs #17631

merged 1 commit into from
Mar 31, 2025

Conversation

varunbharadwaj
Copy link
Contributor

@varunbharadwaj varunbharadwaj commented Mar 19, 2025 •
edited
Loading

Description

This PR adds ingestion management APIs - mainly Pause, Resume and paginated GetIngestionState APIs. This PR is a first version to introduce the APIs and subsequent PRs will build on this to support consumer reset options.

Related Issues

Part of #17442

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for dcccf22: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 19, 2025
Open
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 77aa63a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7402d31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@varunbharadwaj varunbharadwaj force-pushed the vb/ingestionmgmt branch 2 times, most recently from b7617bf to 5756fd0 Compare March 21, 2025 23:24
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 5756fd0: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.14197% with 326 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (edd854a) to head (43211e2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...tadata/MetadataStreamingIngestionStateService.java 11.36% 39 Missing ⚠️
...estion/state/TransportGetIngestionStateAction.java 36.20% 35 Missing and 2 partials ⚠️
...ingestion/pause/TransportPauseIngestionAction.java 17.64% 28 Missing ⚠️
...gestion/resume/TransportResumeIngestionAction.java 17.64% 28 Missing ⚠️
...amingingestion/state/GetIngestionStateRequest.java 54.34% 19 Missing and 2 partials ⚠️
...mingingestion/state/GetIngestionStateResponse.java 40.62% 19 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 0.00% 18 Missing ⚠️
...reamingingestion/IngestionUpdateStateResponse.java 51.42% 17 Missing ⚠️
...ion/admin/indices/RestGetIngestionStateAction.java 18.75% 13 Missing ⚠️
...a/org/opensearch/index/engine/IngestionEngine.java 7.69% 11 Missing and 1 partial ⚠️
... and 20 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17631      +/-   ##
============================================
- Coverage     72.55%   72.38%   -0.17%     
+ Complexity    65966    65948      -18     
============================================
  Files          5326     5350      +24     
  Lines        305548   306185     +637     
  Branches      44322    44373      +51     
============================================
- Hits         221684   221630      -54     
- Misses        65759    66404     +645     
- Partials      18105    18151      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@varunbharadwaj varunbharadwaj changed the title [WIP] [Pull-based Ingestion] Introduce ingestion management APIs [Pull-based Ingestion] Introduce ingestion management APIs Mar 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 371e634: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7eccc3c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 22, 2025
Open
Open
Closed
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 060d76c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

yupeng9
yupeng9 reviewed Mar 22, 2025
View reviewed changes
Copy link
Contributor

@yupeng9 yupeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@varunbharadwaj varunbharadwaj marked this pull request as ready for review March 22, 2025 18:35
@varunbharadwaj varunbharadwaj force-pushed the vb/ingestionmgmt branch 3 times, most recently from ac9d674 to 8e0701f Compare March 28, 2025 17:44
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8e0701f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 28, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3e23e4d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6bd1893: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Mar 29, 2025
Open
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 55703c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 19591d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 43211e2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit 10fb852 into opensearch-project:main Mar 31, 2025
29 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 6, 2025
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 10, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yupeng9 yupeng9 yupeng9 left review comments

@andrross andrross andrross approved these changes

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunbharadwaj @andrross @yupeng9