Introduce mapping transformer to allow transform mappings during index create/update or index template create/update #17635
Conversation
bzhangam
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
bugmakerrrrrr,
jainankitk and
linuxpi
as code owners
github-actions
bot
added
Cluster Manager
enhancement
bzhangam
force-pushed
the
introduceMappingTransformer
branch
from
37b530b to
7d47df7
Compare
| response -> new CreateIndexResponse(response.isAcknowledged(), response.isShardsAcknowledged(), indexName) | ||
| ) | ||
| ); | ||
| }, e -> { throw (RuntimeException) e; }); |
There was a problem hiding this comment.
Exception is threw rather than using listener.onFailure because the behavior before this change is simply throw the exception. We don't want to change the existing behavior of how it handles the exception.
|
❌ Gradle check result for 7d47df7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bzhangam
force-pushed
the
introduceMappingTransformer
branch
2 times, most recently
from
6f9c569 to
dc11eee
Compare
|
❌ Gradle check result for dc11eee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...src/main/java/org/opensearch/action/admin/indices/mapping/put/TransportPutMappingAction.java
Outdated
Show resolved
Hide resolved
...va/org/opensearch/action/admin/indices/template/put/TransportPutComponentTemplateAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/MappingTransformer.java
Outdated
Show resolved
Hide resolved
…ex create/update or index template create/update Signed-off-by: Bo Zhang <[email protected]>
bzhangam
force-pushed
the
introduceMappingTransformer
branch
from
dc11eee to
c35c386
Compare
|
❌ Gradle check result for c35c386: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
In this PR we introduce the mapping transformer to the core to allow transforming the mapping during index create/update and index template create/update. We want to do this because we have a use case in neural search plugin where we want to auto generate the semantic fields(e.g. knn_vector or rank_feature) in the mappings based on the model id defined in the semantic field(A new field type introduced by neural search plugin). In this way we can simplify the neural search set up.
Potentially in future this feature can be leveraged by other plugins to auto transform the mapping based on the certain config defined by users.
Related Issues
Resolves #[17500] - Proposal to introduce the mapping transformer into core.
#[803] - Proposal to support semantic field in neural search.
#[1211] - HLD of the semantic field.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.