-
Notifications
You must be signed in to change notification settings - Fork 2k
Introduce mapping transformer to allow transform mappings during index create/update or index template create/update #17635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce mapping transformer to allow transform mappings during index create/update or index template create/update #17635
Conversation
37b530b
to
7d47df7
Compare
❕ Gradle check result for ceabd64: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17635 +/- ##
============================================
- Coverage 72.57% 72.53% -0.05%
- Complexity 67066 67103 +37
============================================
Files 5470 5475 +5
Lines 309697 309903 +206
Branches 45045 45065 +20
============================================
+ Hits 224776 224790 +14
- Misses 66602 66711 +109
- Partials 18319 18402 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❕ Gradle check result for 077b13c: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
12721cf
to
c88378f
Compare
❌ Gradle check result for c88378f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c88378f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 70be6d0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
70be6d0
to
7eeb323
Compare
8a64e2c
to
afcad68
Compare
Signed-off-by: Bo Zhang <[email protected]>
afcad68
to
c57fbf4
Compare
❕ Gradle check result for c57fbf4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the feedback @bzhangam !
Description
In this PR we introduce the mapping transformer to the core to allow transforming the mapping during index create/update and index template create/update. We want to do this because we have a use case in neural search plugin where we want to auto generate the semantic fields(e.g. knn_vector or rank_feature) in the mappings based on the model id defined in the semantic field(A new field type introduced by neural search plugin). In this way we can simplify the neural search set up.
Potentially in future this feature can be leveraged by other plugins to auto transform the mapping based on the certain config defined by users.
Related Issues
Resolves #[17500] - Proposal to introduce the mapping transformer into core.
#[803] - Proposal to support semantic field in neural search.
#[1211] - HLD of the semantic field.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.