Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Allocation Awareness for Search replicas #17652

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vinaykpud
Copy link
Contributor

Description

This PR adds allocation awareness and awareness balance support for search replica

Related Issues

Resolves #16987
Resolves #17330
Related #15306

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Performance labels Mar 21, 2025
Copy link
Contributor

✅ Gradle check result for 4d100fd: SUCCESS

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (6d53f9d) to head (5bdf41d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...luster/metadata/MetadataUpdateSettingsService.java 37.50% 3 Missing and 2 partials ⚠️
...allocation/decider/AwarenessAllocationDecider.java 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17652      +/-   ##
============================================
+ Coverage     72.40%   72.49%   +0.09%     
- Complexity    65828    65856      +28     
============================================
  Files          5316     5316              
  Lines        305294   305369      +75     
  Branches      44289    44296       +7     
============================================
+ Hits         221033   221370     +337     
+ Misses        66187    65851     -336     
- Partials      18074    18148      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Copy link
Contributor

❌ Gradle check result for 5bdf41d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud closed this Mar 21, 2025
@vinaykpud vinaykpud reopened this Mar 21, 2025
Copy link
Contributor

❌ Gradle check result for 5bdf41d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vinaykpud vinaykpud closed this Mar 21, 2025
@vinaykpud vinaykpud reopened this Mar 21, 2025
Copy link
Contributor

❌ Gradle check result for 5bdf41d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5bdf41d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 5bdf41d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance
Projects
None yet
1 participant