Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Rule-based Auto Tagging] Add rule schema for auto tagging #17653

Merged
merged 2 commits into from
Mar 21, 2025
Merged

[Backport 2.x] [Rule-based Auto Tagging] Add rule schema for auto tagging #17653

merged 2 commits into from
Mar 21, 2025

Conversation

ruai0511
Copy link
Contributor

Backport #17238

@ruai0511
[Rule-based Auto Tagging] Add rule schema for auto tagging (opensearc…
858757f 
…h-project#17238)

Signed-off-by: Ruirui Zhang <[email protected]>

* add rule schema for workload management
Signed-off-by: Ruirui Zhang <[email protected]>

* modify rule structure based on comment
Signed-off-by: Ruirui Zhang <[email protected]>

* update based on comments
Signed-off-by: Ruirui Zhang <[email protected]>

* add javadoc for autotagging directory
Signed-off-by: Ruirui Zhang <[email protected]>

* change field name from 'name' to 'description'
Signed-off-by: Ruirui Zhang <[email protected]>

* update the rule schema
Signed-off-by: Ruirui Zhang <[email protected]>

* simplify autotagging registry
Signed-off-by: Ruirui Zhang <[email protected]>

* remove generic type parameter from Rule class
Signed-off-by: Ruirui Zhang <[email protected]>

* modify based on comments
Signed-off-by: Ruirui Zhang <[email protected]>
(cherry picked from commit b24c72b)
@ruai0511 ruai0511 changed the title [Rule-based Auto Tagging] Add rule schema for auto tagging (#17238) [Backport 2.x] [Rule-based Auto Tagging] Add rule schema for auto tagging Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6adee05: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.32692% with 43 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (87b4b91) to head (6adee05).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...src/main/java/org/opensearch/autotagging/Rule.java 81.63% 6 Missing and 12 partials ⚠️
...java/org/opensearch/autotagging/RuleValidator.java 81.08% 4 Missing and 10 partials ⚠️
...ain/java/org/opensearch/autotagging/Attribute.java 45.45% 5 Missing and 1 partial ⚠️
...rg/opensearch/autotagging/AutoTaggingRegistry.java 83.33% 1 Missing and 2 partials ⚠️
...n/java/org/opensearch/autotagging/FeatureType.java 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17653      +/-   ##
============================================
+ Coverage     72.02%   72.11%   +0.09%     
- Complexity    66032    66163     +131     
============================================
  Files          5342     5347       +5     
  Lines        307289   307497     +208     
  Branches      44848    44892      +44     
============================================
+ Hits         221316   221763     +447     
+ Misses        67505    67269     -236     
+ Partials      18468    18465       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jainankitk jainankitk merged commit e639027 into opensearch-project:2.x Mar 21, 2025
46 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruai0511 @jainankitk