Skip to content

Add simple PolicyParser unit test #17690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

andrross
Copy link
Member

Follow on to #17663. Adding a basic unit test of the policy parsing logic.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a mill , @andrross

Copy link
Contributor

✅ Gradle check result for 63f6804: SUCCESS

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.17%. Comparing base (6d53f9d) to head (63f6804).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17690      +/-   ##
============================================
- Coverage     72.40%   72.17%   -0.23%     
- Complexity    65828    65928     +100     
============================================
  Files          5316     5330      +14     
  Lines        305294   306922    +1628     
  Branches      44289    44651     +362     
============================================
+ Hits         221033   221520     +487     
- Misses        66187    67222    +1035     
- Partials      18074    18180     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 3fb09c7 into opensearch-project:main Mar 25, 2025
57 of 58 checks passed
@andrross andrross deleted the policy-parser-unit-test branch March 25, 2025 23:46
andrross added a commit to andrross/OpenSearch that referenced this pull request Mar 26, 2025
andrross added a commit to andrross/OpenSearch that referenced this pull request Mar 26, 2025
andrross added a commit to andrross/OpenSearch that referenced this pull request Mar 27, 2025
reta pushed a commit that referenced this pull request Mar 28, 2025
* Revert "Add simple PolicyParser unit test (#17690)"

This reverts commit 3fb09c7.

Signed-off-by: Andrew Ross <[email protected]>

* Revert "Add support of Java policies (#17663)"

This reverts commit 17289b7.

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Andrew Ross <[email protected]>
kumargu added a commit to kumargu/OpenSearch that referenced this pull request Apr 1, 2025
Add simple PolicyParser unit test (opensearch-project#17690)

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants