Skip to content

Increasing Floor Segment Size to 16MB #17699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2025
Merged

Increasing Floor Segment Size to 16MB #17699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14a2791
Update the segment floor size
prudhvigodithi Mar 26, 2025
e109020
Add few comments
prudhvigodithi Mar 26, 2025
1ca2f8a
Add few comments
prudhvigodithi Mar 26, 2025
07f2cdc
Merge remote-tracking branch 'upstream/main' into desc-debug
prudhvigodithi Mar 27, 2025
4c57358
Update comment
prudhvigodithi Mar 27, 2025
ed01775
Updated CHANGELOG.md
prudhvigodithi Mar 28, 2025
6a73b0e
Merge remote-tracking branch 'upstream/main' into desc-debug
prudhvigodithi Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Changed
- Migrate BC libs to their FIPS counterparts ([#14912](https://github.com/opensearch-project/OpenSearch/pull/14912))
- Increase the floor segment size to 16MB ([#17699](https://github.com/opensearch-project/OpenSearch/pull/17699))

### Dependencies
- Bump `com.nimbusds:nimbus-jose-jwt` from 9.41.1 to 10.0.2 ([#17607](https://github.com/opensearch-project/OpenSearch/pull/17607), [#17669](https://github.com/opensearch-project/OpenSearch/pull/17669))
Expand Down
6 changes: 5 additions & 1 deletion server/src/main/java/org/opensearch/index/LogByteSizeMergePolicyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ public class LogByteSizeMergePolicyProvider implements MergePolicyProvider {
private final Logger logger;
private final boolean mergesEnabled;

public static final ByteSizeValue DEFAULT_MIN_MERGE = new ByteSizeValue(2, ByteSizeUnit.MB);
/**
* Use 16MB floor size to match Lucene default.
* See <a href="https://github.com/apache/lucene/pull/14189">...</a>
*/
public static final ByteSizeValue DEFAULT_MIN_MERGE = new ByteSizeValue(16, ByteSizeUnit.MB);
public static final int DEFAULT_MERGE_FACTOR = 10;

public static final ByteSizeValue DEFAULT_MAX_MERGED_SEGMENT = new ByteSizeValue(5, ByteSizeUnit.GB);
Expand Down
8 changes: 7 additions & 1 deletion server/src/main/java/org/opensearch/index/TieredMergePolicyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,13 @@ public final class TieredMergePolicyProvider implements MergePolicyProvider {
private final boolean mergesEnabled;

public static final double DEFAULT_EXPUNGE_DELETES_ALLOWED = 10d;
public static final ByteSizeValue DEFAULT_FLOOR_SEGMENT = new ByteSizeValue(2, ByteSizeUnit.MB);

/**
* Use 16MB floor size to match Lucene default.
* See <a href="https://github.com/apache/lucene/pull/14189">...</a>
*/
public static final ByteSizeValue DEFAULT_FLOOR_SEGMENT = new ByteSizeValue(16, ByteSizeUnit.MB);

public static final int DEFAULT_MAX_MERGE_AT_ONCE = 10;
public static final ByteSizeValue DEFAULT_MAX_MERGED_SEGMENT = new ByteSizeValue(5, ByteSizeUnit.GB);
public static final double DEFAULT_SEGMENTS_PER_TIER = 10.0d;
Expand Down
Loading