pass in order terms as sorted to TermInSetQuery() #17714
Conversation
mkhludnev
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for aa495eb: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@mkhludnev thanks for adding this change! This looks right, but |
|
❌ Gradle check result for 4aba2a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5808ce4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17714 +/- ##
============================================
+ Coverage 72.29% 72.39% +0.10%
- Complexity 65900 66026 +126
============================================
Files 5350 5351 +1
Lines 306185 306228 +43
Branches 44373 44374 +1
============================================
+ Hits 221347 221695 +348
+ Misses 66670 66436 -234
+ Partials 18168 18097 -71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for ec7707c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1f18c4d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for 2d73904: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
| } | ||
|
|
||
| @AwaitsFix(bugUrl = "never.ever") | ||
| public void testMockTermsSortedQuery() { |
There was a problem hiding this comment.
how to test constructor argument type?
sadly, I need to remove this test.
let me know if you have an idea.
server/src/main/java/org/opensearch/index/mapper/BytesRefsCollectionBuilder.java
Show resolved
Hide resolved
Signed-off-by: Mikhail Khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for a8b33da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for 4c27562: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❕ Gradle check result for 703d3c4: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for d725111: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
| @@ -256,6 +257,26 @@ public void testMockTermsSortedQuery() { | |||
| } | |||
| } | |||
|
|
|||
| @AwaitsFix(bugUrl = "nocommit") | |||
| public void testHeavyWeight() { | |||
There was a problem hiding this comment.
One more nocommit test. Just a kind of smoke test benchmark.
In my laptop it runs 14 sec vs 8 sec (shuffled vs sorded).
|
❌ Gradle check result for 5d5a85f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for 2938244: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Khludnev <[email protected]>
|
❌ Gradle check result for 38f93f7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Pass in-order terms as Sorted into TermInSet
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
spin off from discussion https://forum.opensearch.org/t/avoid-re-sorting-when-initializing-terminsetquery/23865