Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test AzureBlobStoreRepositoryTests #17905

Merged

Conversation

sachinpkale
Copy link
Member

Description

  • Due to the default SUITE scope on AzureBlobStoreRepositoryTests, the number of documents indexed with each test gets added and huge number of documents and segments created as part of this takes time for snapshot to create and eventually times out the test suite.
  • We can reproduce this issue with following:
/gradlew ':plugins:repository-azure:internalClusterTest' --tests "org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests"  -Dtests.seed=773F78819373DA07
  • As part of this PR, we change the scope to TEST.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for a3af3b9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sachin Kale <[email protected]>
Copy link
Contributor

❌ Gradle check result for 8189f5e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 8189f5e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (1628152) to head (8189f5e).
Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17905      +/-   ##
============================================
+ Coverage     72.43%   72.47%   +0.03%     
- Complexity    66789    66790       +1     
============================================
  Files          5449     5452       +3     
  Lines        309085   309210     +125     
  Branches      44979    44991      +12     
============================================
+ Hits         223899   224085     +186     
+ Misses        66906    66767     -139     
- Partials      18280    18358      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon peterzhuamazon merged commit 5bbb699 into opensearch-project:main Apr 12, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants