Attempt to fix ThreadLeakControl issues in S3BlobStoreRepositoryTests #18317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
nomoa
force-pushed
the
fix-thread-leak-in-S3BlobStoreRepositoryTests
branch
from
ff5460c to
0321e9d
Compare
nomoa
force-pushed
the
fix-thread-leak-in-S3BlobStoreRepositoryTests
branch
from
0321e9d to
e472754
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18317 +/- ##
============================================
+ Coverage 72.50% 72.58% +0.07%
- Complexity 67322 67368 +46
============================================
Files 5488 5488
Lines 311069 311071 +2
Branches 45217 45217
============================================
+ Hits 225547 225776 +229
+ Misses 67118 66938 -180
+ Partials 18404 18357 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
reviewed
May 16, 2025
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3RepositoryPlugin.java
Outdated
Show resolved
Hide resolved
Similar to opensearch-project#18201 but applied via the TestPlugin used in S3BlobStoreRepositoryTests. Closes opensearch-project#14299 Signed-off-by: David Causse <[email protected]>
nomoa
force-pushed
the
fix-thread-leak-in-S3BlobStoreRepositoryTests
branch
from
e472754 to
7c21759
Compare
andrross
approved these changes
May 19, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Storage Project Board
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…opensearch-project#18317) Similar to opensearch-project#18201 but applied via the TestPlugin used in S3BlobStoreRepositoryTests. Closes opensearch-project#14299 Signed-off-by: David Causse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #18201 but applied via the TestPlugin used in S3BlobStoreRepositoryTests.
Related Issues
Resolves #14299
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.