-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Enable include_named_queries_score to be used in msearch #19241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable include_named_queries_score to be used in msearch #19241
Conversation
|
❌ Gradle check result for ea16a22: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ea16a22 to
4b3abd8
Compare
|
❌ Gradle check result for 4b3abd8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4b3abd8 to
1c57e24
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19241 +/- ##
============================================
+ Coverage 73.00% 73.04% +0.04%
- Complexity 70534 70540 +6
============================================
Files 5719 5719
Lines 323260 323266 +6
Branches 46816 46819 +3
============================================
+ Hits 235993 236136 +143
+ Misses 68224 68072 -152
- Partials 19043 19058 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c57e24 to
f241c28
Compare
f241c28 to
7f2bed8
Compare
Contributed on behalf of DataCite – International Data Citation Initiative e.V. Signed-off-by: James Diprose <[email protected]>
7f2bed8 to
c7f01b7
Compare
|
Hey @msfroh, thanks for the tips about how to fix the issue, you couldn't take a look at the PR could you? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Enables support for the
include_named_queries_scorequery parameter in themsearchendpoint.It also fixes an bug with the
searchendpoint where settinginclude_named_queries_scoretotruein the request body (rather than as a URL query parameter) would trigger the computation of named query scores
but not include them in the
SearchHitoutput. This was becauseSearchHitpreviosuly used the URL query parameterto determine whether to write the scores, instead of checking if the scores were present. Fixing this also enables
include_named_queries_scoreto be specified in individual search request bodies inmsearchwith no query parameter.Do I need to
Related Issues
Resolves #19102
API changes companion pull request opensearch-project/opensearch-api-specification#955
Public documentation issue/PR opensearch-project/documentation-website#10888
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.