Making Shard Limit Validator Index Tier Agnostic

[Gagan6164]

Description

Making Shard Limit Validator Index Tier Agnostic

Related Issues

Resolves #19610

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 1f0f270: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 9f7a68e: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 53d5882: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 85ebf51: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 219bb74: SUCCESS

[codecov]

Codecov Report

❌ Patch coverage is 86.04651% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.02%. Comparing base (39b7a59) to head (df40850).
⚠️ Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
...location/decider/ShardsLimitAllocationDecider.java	71.42%	5 Missing and 3 partials ⚠️
...va/org/opensearch/indices/ShardLimitValidator.java	90.76%	5 Missing and 1 partial ⚠️
...luster/metadata/MetadataUpdateSettingsService.java	70.00%	2 Missing and 1 partial ⚠️
...h/cluster/metadata/MetadataCreateIndexService.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19532      +/-   ##
============================================
+ Coverage     73.00%   73.02%   +0.01%     
- Complexity    70534    70570      +36     
============================================
  Files          5719     5719              
  Lines        323260   323346      +86     
  Branches      46816    46826      +10     
============================================
+ Hits         235993   236115     +122     
+ Misses        68224    68198      -26     
+ Partials      19043    19033      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

❌ Gradle check result for 83ea736: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 19efbd1: SUCCESS

[ajaymovva]

Two minor comments. Rest LGTM.

[github-actions]

✅ Gradle check result for c6b2f3f: SUCCESS

[github-actions]

❌ Gradle check result for 13a4506: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 03e7aff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 03e7aff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for df40850: SUCCESS