-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based Ingestion] Fix poller bug and remove persisted pointers #19607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for 4eb43e8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6fabbc4
to
cb49bb0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19607 +/- ##
============================================
- Coverage 73.11% 73.10% -0.01%
+ Complexity 70661 70634 -27
============================================
Files 5724 5725 +1
Lines 323498 323701 +203
Branches 46852 46876 +24
============================================
+ Hits 236518 236655 +137
- Misses 67846 67897 +51
- Partials 19134 19149 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
797bb76
to
4cfe2a1
Compare
❌ Gradle check result for 4cfe2a1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 515649b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 78e0ba0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
…cords when not explicitly configured Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
78e0ba0
to
afaf5e0
Compare
❕ Gradle check result for afaf5e0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…pensearch-project#19607) * fix poller bug and remove persisted pointers * update kafka consumer to use opensearch max_batch_size as max.poll.records when not explicitly configured * fix kinesis tests --------- Signed-off-by: Varun Bharadwaj <[email protected]>
Description
This PR fixes the following bugs and inefficiencies.
auto.offset.reset
Kafka setting tonone
by default to throw errors on out-of-bounds offsets. This could be possible if the ingestion was paused and exceeds Kafka retention period. The user will be able to monitor consumer errors to identify this error and handle it accordingly. User still has the choice to setauto.offset.reset
to earliest/latest.auto.offset.reset
to earliest/latest and offset is out-of-bounds. Instead, the OpenSearch consumer settingpoll.max_batch_size
is used in place ofmax.poll.records
for Kafka consumer initialization to control batch size. Ifmax.poll.records
is configured by user, it takes precedence.Related Issues
Resolves #19591
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.