Skip to content

Conversation

darjisagar7
Copy link

Description

Adding new Feature Flag for Pluggable Dataformat implementation

Related Issues

RFC #18416
RFC #18847

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@darjisagar7 darjisagar7 requested a review from a team as a code owner October 17, 2025 12:50
Copy link
Contributor

❌ Gradle check result for f572e08: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sagar Darji <[email protected]>
@mch2
Copy link
Member

mch2 commented Oct 17, 2025

Thinking we should introduce a fflag for the entire engine pluggability effort vs a scoped one to dataformat, that gates the extension point higher up, wdyt? Does that make sense for this? I think we should be introducing new flags with some kind of implementation of what its gating to get a better idea.

Copy link
Contributor

✅ Gradle check result for 9c5090f: SUCCESS

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.19%. Comparing base (133e9d9) to head (a21ff78).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19675      +/-   ##
============================================
+ Coverage     73.11%   73.19%   +0.08%     
- Complexity    70838    70843       +5     
============================================
  Files          5732     5732              
  Lines        324191   324248      +57     
  Branches      46922    46923       +1     
============================================
+ Hits         237017   237340     +323     
+ Misses        68068    67785     -283     
- Partials      19106    19123      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgodwan
Copy link
Member

mgodwan commented Oct 21, 2025

@mch2 I think it still make sense to have a feature flag to gate any change control around how pluggability is being integrated into the core (e.g. mapper, query orchestration, engine) which this PR aims to cover, and then beyond it, we can have a feature flag to denote whether certain experimental format/engine is enabled or not.

Copy link
Contributor

❕ Gradle check result for a21ff78: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants