-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Adding new Feature Flag for Pluggable Dataformat implementation #19675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sagar Darji <[email protected]>
❌ Gradle check result for f572e08: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sagar Darji <[email protected]>
Thinking we should introduce a fflag for the entire engine pluggability effort vs a scoped one to dataformat, that gates the extension point higher up, wdyt? Does that make sense for this? I think we should be introducing new flags with some kind of implementation of what its gating to get a better idea. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19675 +/- ##
============================================
+ Coverage 73.11% 73.19% +0.08%
- Complexity 70838 70843 +5
============================================
Files 5732 5732
Lines 324191 324248 +57
Branches 46922 46923 +1
============================================
+ Hits 237017 237340 +323
+ Misses 68068 67785 -283
- Partials 19106 19123 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mch2 I think it still make sense to have a feature flag to gate any change control around how pluggability is being integrated into the core (e.g. mapper, query orchestration, engine) which this PR aims to cover, and then beyond it, we can have a feature flag to denote whether certain experimental format/engine is enabled or not. |
❕ Gradle check result for a21ff78: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
Adding new Feature Flag for Pluggable Dataformat implementation
Related Issues
RFC #18416
RFC #18847
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.