Adding bulk collect API for filter rewrite sub aggregation collection #19933
+197
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainankitk
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
Author
|
{"run-benchmark-test": "id_3"} |
jainankitk
changed the title
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/4977/ . Final results will be published once the job is completed. |
Contributor
|
❌ Gradle check result for 1263c1d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/4977/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/179/
|
Contributor
Author
|
{"run-benchmark-test": "id_10"} |
Contributor
Author
|
{"run-benchmark-test": "id_11"} |
Contributor
Author
|
{"run-benchmark-test": "id_12"} |
Contributor
Author
|
{"run-benchmark-test": "id_12"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/5025/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/5025/
|
Contributor
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/186/
|
Contributor
Author
|
{"run-benchmark-test": "id_10"} |
Contributor
Author
|
{"run-benchmark-test": "id_11"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/5026/ . Final results will be published once the job is completed. |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/5027/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/5024/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/187/
|
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/5026/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/188/
|
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/5027/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/189/
|
Signed-off-by: Ankit Jain <[email protected]>
Contributor
|
❌ Gradle check result for 262d674: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
Contributor
Author
|
{"run-benchmark-test": "id_12"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/5028/ . Final results will be published once the job is completed. |
Contributor
|
❌ Gradle check result for a9a933a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/5028/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/190/
|
Contributor
Author
|
Flaky test failure: Retrying gradle check |
Contributor
Contributor
Author
|
Okay, ended up running quite a few benchmarks. Summarizing my observations for the reviewer:
Before the change
After the specific commit
Overall, this PR is just about laying the groundwork. We should be able to provide aggregator specific implementation for each of these bulk collect apis, which should further the performance even more. Tried this out as POC for I will start creating issue/PRs for aggregation specific optimizations once this PR gets merged in! |
rishabhmaurya
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filter rewrite optimization for numeric bucket aggregation is able to multi range traverse over BKD, and provide matching documents bitset for each top level bucket. Individually invoking sub collectors for each docId for same bucket is wasteful, and can be done more efficient using bulk collection API. This PR adds such an API to
BucketLeafCollectorand invokes the same from few placesRelated Issues
Related #19324
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.