Refactor TranslogStats and RequestCacheStats with Builder pattern #19961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19961 +/- ##
============================================
+ Coverage 73.25% 73.28% +0.02%
+ Complexity 71612 71563 -49
============================================
Files 5785 5785
Lines 326905 326960 +55
Branches 47280 47285 +5
============================================
+ Hits 239480 239597 +117
+ Misses 68220 68080 -140
- Partials 19205 19283 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pado0
force-pushed
the
builder-translog-requestcache-stats
branch
from
a09b7ef to
cad2c73
Compare
pado0
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
❌ Gradle check result for d6eea39: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
sandeshkr419
approved these changes
Nov 12, 2025
server/src/main/java/org/opensearch/index/translog/TranslogStats.java
Outdated
Show resolved
Hide resolved
pado0
force-pushed
the
builder-translog-requestcache-stats
branch
from
df1a02f to
daf729f
Compare
Contributor
|
❌ Gradle check result for daf729f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
pado0
force-pushed
the
builder-translog-requestcache-stats
branch
from
cb3fa9a to
ccf1db9
Compare
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
Signed-off-by: Jean Kim <[email protected]>
pado0
force-pushed
the
builder-translog-requestcache-stats
branch
from
ccf1db9 to
30aecd9
Compare
Contributor
sandeshkr419
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
TranslogStatsandRequestCacheStatsclass to use the Builder pattern instead of relying on multiple constructors.By adopting the Builder pattern, it becomes easier to evolve the stats API, add new metrics, and maintain backward compatibility without forcing disruptive constructor changes.
Based on the related issue:
There are multiple stats-related classes that need similar refactoring, and we are addressing them in priority order. This PR covers
TranslogStatsandRequestCacheStatsas part of that effort.Related Issues
Related to #19225
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.