Analytics-engine: Update coordinator reduce to use search threadpool#21756
Merged
Conversation
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Bukhtawar
approved these changes
May 20, 2026
Contributor
Bukhtawar
left a comment
There was a problem hiding this comment.
Looks good, we need to ensure DF doesn't become a bottleneck
Contributor
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21756 +/- ##
============================================
+ Coverage 73.33% 73.38% +0.05%
- Complexity 74996 75003 +7
============================================
Files 6012 6012
Lines 340934 340934
Branches 49076 49076
============================================
+ Hits 250021 250198 +177
+ Misses 71005 70752 -253
- Partials 19908 19984 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run the coordinator reduce on the SEARCH pool instead of a virtual thread
This also properly wires up AbstractRunnable to handle rejection.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.