Skip to content

Analytics-engine: Update coordinator reduce to use search threadpool#21756

Merged
mch2 merged 1 commit into
opensearch-project:mainfrom
mch2:vt
May 20, 2026
Merged

Analytics-engine: Update coordinator reduce to use search threadpool#21756
mch2 merged 1 commit into
opensearch-project:mainfrom
mch2:vt

Conversation

@mch2
Copy link
Copy Markdown
Member

@mch2 mch2 commented May 20, 2026

Description

Run the coordinator reduce on the SEARCH pool instead of a virtual thread

This also properly wires up AbstractRunnable to handle rejection.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 requested a review from a team as a code owner May 20, 2026 09:56
@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

Copy link
Copy Markdown
Contributor

@bharath-techie bharath-techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to ensure DF doesn't become a bottleneck

@Bukhtawar
Copy link
Copy Markdown
Contributor

uite: Test class org.opensearch.analytics.exec.stage.ReduceStageExecutionTests
  2> REPRODUCE WITH: ./gradlew ':sandbox:plugins:analytics-engine:test' --tests 'org.opensearch.analytics.exec.stage.ReduceStageExecutionTests.testBufferedStartInvokesReduceAndTerminalInvokesClose' -Dtests.seed=94836B2179BDF53D -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-FI -Dtests.timezone=Africa/Accra -Druntime.java=25
  2> java.lang.NullPointerException: Cannot invoke "java.util.concurrent.Executor.execute(java.lang.Runnable)" because "this.executor" is null
        at __randomizedtesting.SeedInfo.seed([94836B2179BDF53D:1D23DC907AA0ADD9]:0)
        at org.opensearch.analytics.exec.stage.coordinator.LocalTaskRunner.run(LocalTaskRunner.java:46)
        at org.opensearch.analytics.exec.stage.coordinator.LocalTaskRunner.run(LocalTaskRunner.java:25)
        at org.opensearch.analytics.exec.stage.ReduceStageExecutionTests.scheduleAndDispatch(ReduceStageExecutionTests.java:272)
        at org.opensearch.analytics.exec.stage.ReduceStageExecutionTests.testBufferedStartInvokesReduceAndTerminalInvokesClose(ReduceStageExecutionTests.java:76)

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for f584b0d: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.38%. Comparing base (debf6ed) to head (f584b0d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #21756      +/-   ##
============================================
+ Coverage     73.33%   73.38%   +0.05%     
- Complexity    74996    75003       +7     
============================================
  Files          6012     6012              
  Lines        340934   340934              
  Branches      49076    49076              
============================================
+ Hits         250021   250198     +177     
+ Misses        71005    70752     -253     
- Partials      19908    19984      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mch2 mch2 merged commit 3ddd784 into opensearch-project:main May 20, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants