[Extensions] Moving ExtensionsRequest to use Protobuf#6960
[Extensions] Moving ExtensionsRequest to use Protobuf#6960saratvemulapalli merged 20 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
@reta @owaiskazi19 @peternied @VachaShah sorry couldn't get back to this since a week. The change is now ready for review. Everything works :) |
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
| archivesBaseName = 'opensearch' | ||
|
|
||
| sourceSets { | ||
| main { |
| } | ||
| } | ||
|
|
||
| tasks.named("missingJavadoc").configure { |
|
Nice one @saratvemulapalli , pretty clean and simple |
There was a problem hiding this comment.
Overall LGTM! Thanks for addressing the feedback @saratvemulapalli! Do you think we should add tests for the generated Protobuf classes?
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Tests for generated classes, I am like "protoc" can you generate unit tests too :D. |
Looks like 2.7 is on its way, i'll rebase my PR. |
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6960-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0f7c192baa574407d9d081343fd6318c092cbc5
# Push it to GitHub
git push --set-upstream origin backport/backport-6960-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
…ject#6960) Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
…ject#6960) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
As part of opensearch-project/opensearch-sdk-java#337. Moving the first API to protobuf to have seamless version support.
Issues Resolved
Part of #opensearch-project/opensearch-sdk-java#642
Also first introduction of protobuf #6844
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.