Fix remote cluster bug when remote and local have same name #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
requested review from
dbwiddis,
jackiehanyang,
joshpalis,
kaituo,
ohltyler,
owaiskazi19 and
sean-zheng-amazon
as code owners
jackiehanyang
approved these changes
Apr 7, 2025
|
I am not able to see remote cluster when editing a detector. Can you fix it as well?
Here is how I fixed it on forecasting: https://github.com/kaituo/anomaly-detection-dashboards-plugin/blob/forecasting2/public/pages/DefineForecaster/components/Datasource/DataSource.tsx#L130-L142 I am fine you doing it in another PR. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
…al (#1007) Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 7454a4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 2 different bugs related to remote cluster display during detector creation:
Both these cases are covered in new IT in this PR: opensearch-project/opensearch-dashboards-functional-test#1755
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.