[Backport 3.1] fix: fetch full forecaster list, and fix delete bug #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=80&v=4){kind=small}
…lete bug (#1068) - Enforce a minimum shingle size (`min={4}`) in `SuggestParametersDialog` to prevent invalid configurations. - Fetch the complete forecaster list by explicitly passing `size: MAX_FORECASTER` in `forecast.searchForecaster`; replace wildcard imports with `MAX_FORECASTER`. - Remove unnecessary `console.log` statements and commented-out code from `ForecasterActionsCell` and `ForecastersList` for cleaner output. - Fix the delete-action bug where deleting the selected forecaster incorrectly deleted the last forecaster in the list. Now correctly uses the selected forecaster's object for retrieving the name and ID. Testing: - Manual verification completed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit ee744b6)
opensearch-trigger-bot
bot
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
kaituo,
ohltyler,
owaiskazi19 and
sean-zheng-amazon
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.1 #1070 +/- ##
======================================
Coverage ? 48.67%
======================================
Files ? 232
Lines ? 10613
Branches ? 2287
======================================
Hits ? 5166
Misses ? 4911
Partials ? 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ee744b6 from #1068