Skip to content

Conversation

@gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Oct 21, 2024

Description

This PR adds some small enhancements and fixes some bugs for the suggestAD feature, which contains:

  1. Do not show the suggestAD action button if the data source of the selected index pattern has no AI agent.
  2. If the selected index pattern doesn't have time field, then we use the root level date type field as the default timestamp field.
  3. If cannot find any date type field from the mappings of the selected index pattern, then pops up an error.
  4. Feature name cannot be longer than 64, so we truncate the feature name if it exceeds the limit.

Issues Resolved

#816

AD.mov

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Copy link
Contributor Author

@jackiehanyang could you help to review this PR, thanks!

@kaituo kaituo merged commit 7b60fed into opensearch-project:main Oct 22, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 22, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
kaituo pushed a commit that referenced this pull request Oct 23, 2024
#905)

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 7b60fed)

Co-authored-by: gaobinlong <[email protected]>
kaituo pushed a commit that referenced this pull request Oct 23, 2024
#906)

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 7b60fed)

Co-authored-by: gaobinlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants