[Backport 2.x] backporting PRs 1422, 1414, 1441 to 2.x

[amitgalitz]

Description

backporting PRs #1422, #1414, #1441 to 2.x

Check List

• Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (019756a) to head (5718cde).

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #1442      +/-   ##
============================================
- Coverage     81.63%   81.63%   -0.01%     
+ Complexity     5871     5869       -2     
============================================
  Files           533      533              
  Lines         23665    23665              
  Branches       2374     2374              
============================================
- Hits          19320    19318       -2     
+ Misses         3188     3187       -1     
- Partials       1157     1160       +3     

Flag	Coverage Δ
plugin	81.63% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[amitgalitz]

@cwperks Hey Craig I am backporting your change along with others to 2.x and I the latest code to get the job-scheduler file is having issues on getting 1.3.2 as you see in the CI.
The main cause here I think is due to this being removed:

plugin(provider(new Callable<RegularFile>(){
                @Override
                RegularFile call() throws Exception {
                    return new RegularFile() {
                        @Override
                        File getAsFile() {
                            if (new File("$project.rootDir/$bwcFilePath/job-scheduler/$bwcVersion").exists()) {
                                project.delete(files("$project.rootDir/$bwcFilePath/job-scheduler/$bwcVersion"))
                            }
                            project.mkdir bwcJobSchedulerPath + bwcVersion
                            ant.get(src: bwcOpenSearchJSDownload,
                                    dest: bwcJobSchedulerPath + bwcVersion,
                                    httpusecaches: false)
                            return fileTree(bwcJobSchedulerPath + bwcVersion).getSingleFile()
                        }
                    }
                }
            }))
            

Is it reasonable for the bwc section to return to using this? I think more specifically we were able to get job scheduler 1.3.2 for 2.x bwc tests from:
bwcOpenSearchJSDownload = 'https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/' + bwcVersionShort + '/latest/linux/x64/tar/builds/' +
'opensearch/plugins/opensearch-job-scheduler-' + bwcVersion + '.zip'

[cwperks]

@amitgalitz 1.3.2 is fairly old, is it possible to refer to a later patch release for 1.3 like 1.3.19? What about using released artifacts instead of snapshot? Released artifacts will never be deleted.

[prudhvigodithi]

1.3.2 is fairly old, is it possible to refer to a later patch release for 1.3 like 1.3.19? What about using released artifacts instead of snapshot? Released artifacts will never be deleted.

Yes I would recommend the same using released artifacts by removing -SNAPSHOT for already released versions.