Construct dummy request for doc level monitor fanout request on serde failure #806
+139
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failure Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
sbcd90,
AWSHurneyt,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to handle failures in doc level monitor fanout request construction during upgrades when nodes from old and new versions co-exist we create a dummy request if serde fails.
This situation occurs as new fields have been added without version check in monitor object which causes serde failures when doc level monitor execution starts on a node in older version and fans out to a node on a newer version with different serialization code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.