fix: remove text in badge to make it compatible with small screen #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <[email protected]>
wanglam
approved these changes
Mar 15, 2025
Qxisylolo
pushed a commit
to Qxisylolo/dashboards-assistant
that referenced
this pull request
Apr 2, 2025
…ensearch-project#509) * fix: remove text to make badge compatible with small screen Signed-off-by: tygao <[email protected]> * style: update style and changelog Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Oui badge doesn't support resize and the minimum size of it will overlap in alerting table, remove text in badge to make it compatible with small screen. Will update this once confirmed with UX for a more complete solution.
Screenshot
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.