Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the no aggregation PPL error message #512

Merged
merged 3 commits into from
Mar 17, 2025
Merged

update the no aggregation PPL error message #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e674bb
update the no aggregation PPL error message
yyfamazon Mar 17, 2025
1276273
Merge branch 'main' into aggregationError
yyfamazon Mar 17, 2025
518e0d4
update release notes
yyfamazon Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/utils/pipeline/text_to_ppl_task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class Text2PPLTask extends Task<Input, Input & { ppl: string }> {
const hasStats = statsRegex.test(ppl);
if (!hasStats) {
throw new Error(
`The generated PPL query: ${ppl} doesn't seem to contain an aggregation. Ensure your question contains data aggregation (e.g., average, sum, or count) for meaningful visualization.`
`The generated PPL query doesn't seem to contain an aggregation. Ensure your question contains an aggregation (e.g., average, sum, or count) to create a meaningful visualization. Generated PPL: ${ppl}`
);
}
}
Expand Down
2 changes: 2 additions & 0 deletions release-notes/dashboards-assistant.release-notes-3.0.0.0-alpha1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.0.0-alpha1
- Add http error instruction for t2ppl task ([#502](https://github.com/opensearch-project/dashboards-assistant/pull/502))
- Change the background color, button position and text for alert summary popover ([#506](https://github.com/opensearch-project/dashboards-assistant/pull/506))
- collect metrics for when t2viz triggered([#510](https://github.com/opensearch-project/dashboards-assistant/pull/510))
- chatbot dock bottom border top([#511](https://github.com/opensearch-project/dashboards-assistant/pull/511))
- update the no aggregation PPL error message([#512](https://github.com/opensearch-project/dashboards-assistant/pull/512))

### Bug Fixes

Expand Down
Loading