Add auto aggregation suggest for t2v #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
wanglam and
raintygao
as code owners
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
wanglam
reviewed
Mar 20, 2025
gaobinlong
reviewed
Mar 20, 2025
| ppl = `${ppl} | stats count()`; | ||
| } else { | ||
| // get min and max and calculate proper interval by range | ||
| const min = res.rawResponse.jsonData[0].min; |
There was a problem hiding this comment.
If the generated ppl contains time range condition, then should we use that condition directly to narrow down the time range? Too many buckets maybe created if we use the max/min time in the index, which has poor performance.
There was a problem hiding this comment.
we didn't remove any filter in original ppl, what we do is get the range for existing query result and append a date histogram aggregation
Signed-off-by: Hailong Cui <[email protected]>
ruanyl
approved these changes
Mar 20, 2025
wanglam
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add auto aggregation suggest for t2v. It will depends on whether index pattern has time field or not, if it don't have time field, will simply use
countas aggregation method, otherwise, trying to figure out the best interval for date histogramIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.