Skip to content

consolidate responses and errors into console section #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: feature/editor-refactor
Choose a base branch
from
Open

consolidate responses and errors into console section #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
212ac68
resolve merge conflicts
Jun 2, 2025
1f928e6
fix console bottom padding and console text padding issue
Jun 5, 2025
5d7f1c2
fix left nav button bottom space
Jun 5, 2025
96e442b
fix dark mode
Jun 6, 2025
a3b5c93
fix full screen page
Jun 6, 2025
e94b2fd
address comments till error count refactor
Jun 6, 2025
5ece18d
last function check. works well
Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,23 +886,31 @@ export const INSPECTOR_TABS = [
disabled: false,
},
{
id: INSPECTOR_TAB_ID.INGEST,
name: 'Ingest response',
id: INSPECTOR_TAB_ID.RESOURCES,
name: 'Resources',
disabled: false,
},
{
id: INSPECTOR_TAB_ID.ERRORS,
name: 'Errors',
id: INSPECTOR_TAB_ID.PREVIEW,
name: 'Preview',
disabled: false,
},
];

export enum CONSOLE_TAB_ID {
ERRORS = 'errors',
INGEST_RESPONSE = 'ingest_response',
}

export const CONSOLE_TABS = [
{
id: INSPECTOR_TAB_ID.RESOURCES,
name: 'Resources',
id: CONSOLE_TAB_ID.ERRORS,
name: 'Errors',
disabled: false,
},
{
id: INSPECTOR_TAB_ID.PREVIEW,
name: 'Preview',
id: CONSOLE_TAB_ID.INGEST_RESPONSE,
name: 'Ingest Response',
disabled: false,
},
];
Expand Down
1,161 changes: 1,161 additions & 0 deletions output.txt
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still exists, please remove

Large diffs are not rendered by default.

31 changes: 22 additions & 9 deletions public/pages/workflow_detail/left_nav/left_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ import {
reduceToTemplate,
sleep,
uiConfigToFormik,
USE_NEW_HOME_PAGE,
useDataSourceVersion,
useMissingDataSourceVersion,
} from '../../../utils';
Expand Down Expand Up @@ -86,6 +85,7 @@ interface LeftNavProps {
setSearchReadonly: (readonly: boolean) => void;
setIsProvisioning: (isProvisioning: boolean) => void;
onClose: () => void;
isConsolePanelOpen: boolean;
}

const SUCCESS_TOAST_ID = 'success_toast_id';
Expand Down Expand Up @@ -704,6 +704,7 @@ export function LeftNav(props: LeftNavProps) {
.unwrap()
.then((resp: SimulateIngestPipelineResponseVerbose) => {
const ingestPipelineErrors = getIngestPipelineErrors(resp);

// The errors map may be empty; in which case, this dispatch will clear
// any older errors.
dispatch(
Expand Down Expand Up @@ -797,10 +798,7 @@ export function LeftNav(props: LeftNavProps) {
grow={false}
className="workspace-panel left-nav-static-width"
borderRadius="l"
style={{
paddingBottom: '48px',
marginRight: '0px',
}}
style={{ paddingBottom: '12px' }}
>
<EuiFlexItem grow={false}>
<EuiFlexGroup direction="row" justifyContent="spaceBetween">
Expand Down Expand Up @@ -831,7 +829,6 @@ export function LeftNav(props: LeftNavProps) {
style={{
height: '100%',
gap: '16px',
//marginLeft: '12px', TODO: change this value to adjust global margin of left nav.
}}
>
<EuiFlexItem
Expand Down Expand Up @@ -895,11 +892,13 @@ export function LeftNav(props: LeftNavProps) {
)}
</>
</EuiFlexItem>
<EuiFlexItem grow={false}>

<EuiFlexItem grow={true}>
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
<EuiHorizontalRule margin="m" />
</EuiFlexItem>

{onIngestAndSearchUpdateRequired && (
<EuiFlexItem grow={false} style={{ marginTop: '-8px' }}>
<EuiCallOut
Expand All @@ -920,13 +919,27 @@ export function LeftNav(props: LeftNavProps) {
/>
</EuiFlexItem>
)}
<EuiFlexItem grow={false}>
<EuiFlexItem
grow={false}
style={{
height: '60px',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
marginBottom: '20px',
}}
>
<EuiFlexGroup
direction="row"
gutterSize="s"
style={{
padding: '0px',
marginBottom: USE_NEW_HOME_PAGE ? '0px' : '54px',
margin: '0px',
width: '100%',
height: '100%',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
Comment on lines +922 to +942
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should not be necessary, why all of the width/height styling changes? EuiFlexGroup will already grow to maximize space within their parent container.

Additionally, the USE_NEW_HOME_PAGE flag has been removed; this was required to maximize the space based on OSD using the new home page layout vs. old home page layout. Please add back.

}}
>
{onIngestAndUnprovisioned &&
Expand Down
Loading
Loading