-
Notifications
You must be signed in to change notification settings - Fork 19
Added workflow template for Semantic Search using Sparse Encoders #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added workflow template for Semantic Search using Sparse Encoders #742
Conversation
Will Rebase this PR. Feature branch commits merged causing commit conflicts. |
) * Integrate preview panel into inspector panel (opensearch-project#722) * finish merging preview Signed-off-by: Kama Huang <[email protected]> fix rendering size Signed-off-by: Kama Huang <[email protected]> fix format Signed-off-by: Kama Huang <[email protected]> fix tests Signed-off-by: Kama Huang <[email protected]> modify change log Signed-off-by: Kama Huang <[email protected]> * add comments about why reactflow cannot render graphs Signed-off-by: Kama Huang <[email protected]> --------- Signed-off-by: Kama Huang <[email protected]> Co-authored-by: Kama Huang <[email protected]> * Refactor form navigation to left panel (opensearch-project#724) Signed-off-by: Tyler Ohlsen <[email protected]> * More left panel changes; update UT (opensearch-project#732) Signed-off-by: Tyler Ohlsen <[email protected]> * Misc improvements (opensearch-project#734) Signed-off-by: Tyler Ohlsen <[email protected]> * Misc improvements II (opensearch-project#735) * Tune missing interface callout and show in quick-config Signed-off-by: Tyler Ohlsen <[email protected]> * Move edit source data to top-level in component_input Signed-off-by: Tyler Ohlsen <[email protected]> * various source data modal improvements Signed-off-by: Tyler Ohlsen <[email protected]> * Persist search button after running search in edit query modal Signed-off-by: Tyler Ohlsen <[email protected]> * make btn empty Signed-off-by: Tyler Ohlsen <[email protected]> * left nav spacing nits Signed-off-by: Tyler Ohlsen <[email protected]> * Make invalid search options at least visible Signed-off-by: Tyler Ohlsen <[email protected]> * Expand accordion by default if list is empty Signed-off-by: Tyler Ohlsen <[email protected]> * Remount accordion based on initialIsOpen prop Signed-off-by: Tyler Ohlsen <[email protected]> * Tune spacing on status and btns in left nav Signed-off-by: Tyler Ohlsen <[email protected]> * more left nav overflow fixes Signed-off-by: Tyler Ohlsen <[email protected]> * Fix overflow on search collaps Signed-off-by: Tyler Ohlsen <[email protected]> * Fix typo in comment Signed-off-by: Tyler Ohlsen <[email protected]> * Make btn match mock Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> * Misc improvements III (opensearch-project#736) Signed-off-by: Tyler Ohlsen <[email protected]> * fix-deps (opensearch-project#738) Signed-off-by: Tyler Ohlsen <[email protected]> * Increment version to 3.1.0.0 (opensearch-project#723) (opensearch-project#741) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]> --------- Signed-off-by: Kama Huang <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: kamahuan <[email protected]> Co-authored-by: Kama Huang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]>
036bb0c
to
766ad2f
Compare
d3f4d1b
to
b1a758b
Compare
0fd0454
to
dad80a3
Compare
Signed-off-by: saimedhi <[email protected]>
dad80a3
to
0bf13fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I'll do some more testing on it soon. Few very minor comments.
Tested few other use cases end-to-end additionally, looks good! I'd suggest to have open issues regarding the documentation, and have them linked as an open issue in our repo as well. |
Signed-off-by: saimedhi <[email protected]>
|
Signed-off-by: saimedhi <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-742-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 47e06cf0ef627fb624807a07f5f60e2906d25b71
# Push it to GitHub
git push --set-upstream origin backport/backport-742-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-flow-framework/backport-2.x Then, create a pull request where the |
Description
Onboarding a new workflow preset for Semantic Search using Sparse Encoders
For development used "opensearch-neural-sparse-encoding-v2-distill" deployed on sagemaker endpoint.
Query used in Search Flow is Match query overridden with neural sparse query.
Closed previous Neural Sparse Search PR Adding Neural Sparse Search preset #687 (As stated in previous PR a bug was detected while parsing the sparse vector to perform neural sparse search. It got fixed in Adds Json Parsing to nested object during update Query step in ML Inference Request processor ml-commons#3856)
screen-capture.29.webm
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.