Change jsonpath dep to jsonpath-plus
#756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
minalsha,
owaiskazi19 and
saimedhi
as code owners
|
Will rebase after changelog changes merged from #757 first. |
joshpalis
approved these changes
Jul 30, 2025
jackiehanyang
approved these changes
Jul 30, 2025
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-756-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c76018aa7431b0e671413785fef9f9cf674f0941
# Push it to GitHub
git push --set-upstream origin backport/backport-756-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-flow-framework/backport-2.xThen, create a pull request where the |
ohltyler
added a commit
to ohltyler/dashboards-flow-framework
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Tyler Ohlsen <[email protected]>
1 task
|
Manual backport: #760 |
ohltyler
added a commit
that referenced
this pull request
Jul 31, 2025
* Change `jsonpath` dep to `jsonpath-plus` (#756) Signed-off-by: Tyler Ohlsen <[email protected]> * tune changelog Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the jsonpath dependency from jsonpath to jsonpath-plus.
jsonpath-plusis a safer, more popular npm package for executing jsonpath. There is no maintenance on thejsonpathgithub package for 4 years, while thejsonpath-pluspackage is maintained and updated regularly.Also updates the corresponding 'Learn more' link to point to the newer npm package on the UI.
Tested that the execution works as expected on the UI, including for arrays and nested objects. Based on the documentation, the new
JSONPath()function (withwrap:true) is identical to thequery()function used from the older package.Issues Resolved
None
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.