Handle NPE of no agents system index found #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
minalsha,
owaiskazi19 and
saimedhi
as code owners
owaiskazi19
approved these changes
Oct 2, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 081222a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Oct 2, 2025
(cherry picked from commit 081222a) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to set a default value for the redux
agentsfield, if there is exceptions during search agents API call, by adding checks in 2 places:index_not_found_exceptionwhich can occur on init clusters during plugin search calls, when the system indices have not been created yet. This is duplicate logic that is already in the search workflows API call, copied over to the search agents call. Also copied to the search models & search connectors calls.agentsredux store var, if it is for some reason set to an undefined value.Note, these issues are only arising on docker-container clusters. Unable to reproduce in a dev environment. Something is causing API failures to OpenSearch to not be registered as
rejectedin the redux store, leading to the store variables being corrupted and set to these unsafe / empty values, likeundefined. Tracking issue here: #788Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.