Skip to content

Separate agentic and classic notebook into two components #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: hypothesis-investigtion
Choose a base branch
from
+863 −601
Open

Separate agentic and classic notebook into two components #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/types/notebooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

export interface OptionsType {
baseUrl: string;
payload?: any;

Check warning on line 8 in common/types/notebooks.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
headers?: any;

Check warning on line 9 in common/types/notebooks.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
redirects?: number;
beforeRedirect?: any;

Check warning on line 11 in common/types/notebooks.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
redirected?: any;

Check warning on line 12 in common/types/notebooks.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
timeout?: number; // default: unlimited
maxBytes?: number; // default: unlimited
rejectUnauthorized?: boolean;
Expand Down Expand Up @@ -39,7 +39,7 @@
baselineTo: number;
};
source?: NoteBookSource;
filters?: Array<Record<string, any>>; // For phase 1, we only support DSL filter

Check warning on line 42 in common/types/notebooks.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
summary?: string;
PPLFilters?: string[];
variables?: {
Expand Down Expand Up @@ -177,3 +177,7 @@
hypothesis: PERAgentHypothesisItem;
operation: 'CREATE' | 'REPLACE';
}

export interface NotebookComponentProps {
showPageHeader?: boolean;
}
393 changes: 393 additions & 0 deletions ...ic/components/notebooks/components/__tests__/__snapshots__/classic_notebook.test.tsx.snap
View file
Open in desktop

Large diffs are not rendered by default.

394 changes: 0 additions & 394 deletions public/components/notebooks/components/__tests__/__snapshots__/notebook.test.tsx.snap
View file
Open in desktop

This file was deleted.

22 changes: 15 additions & 7 deletions ...ks/components/__tests__/notebook.test.tsx → ...nents/__tests__/classic_notebook.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ import {
notebookPutResponse,
runCodeBlockResponse,
} from '../../../../../test/notebooks_constants';
import { Notebook, NotebookProps } from '../notebook';
import { ClassicNotebook, ClassicNotebookProps } from '../classic_notebook';
import {
applicationServiceMock,
chromeServiceMock,
notificationServiceMock,
savedObjectsServiceMock,
Expand Down Expand Up @@ -138,7 +139,8 @@ jest.mock('../../../../../public/services', () => ({
})),
}));

const ContextAwareNotebook = (props: NotebookProps & { dataSourceEnabled?: boolean }) => {
const ContextAwareNotebook = (props: ClassicNotebookProps & { dataSourceEnabled?: boolean }) => {
const applicationMock = applicationServiceMock.createStartContract();
return (
<OpenSearchDashboardsContextProvider
services={{
Expand Down Expand Up @@ -170,13 +172,19 @@ const ContextAwareNotebook = (props: NotebookProps & { dataSourceEnabled?: boole
ParagraphComponent: () => <div data-test-subj="mock-paragraph" />,
}),
},
updateContext: jest.fn(),
findingService: {
initialize: jest.fn(),
application: {
...applicationMock,
capabilities: {
...applicationMock.capabilities,
investigation: {
...applicationMock.capabilities.investigation,
agenticFeaturesEnabled: true,
},
},
},
}}
>
<Notebook {...props} />
<ClassicNotebook {...props} />
</OpenSearchDashboardsContextProvider>
);
};
Expand All @@ -189,7 +197,7 @@ describe('<Notebook /> spec', () => {
const history = jest.fn() as any;
history.replace = jest.fn();
history.push = jest.fn();
const defaultProps: NotebookProps = {
const defaultProps: ClassicNotebookProps = {
openedNoteId: '458e1320-3f05-11ef-bd29-e58626f102c0',
showPageHeader: true,
};
Expand Down
Loading
Loading