[Backport 2.x] Traces custom source - Bug Fixes #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix custom traces filter bug, add default metric selection Signed-off-by: Adam Tackett <[email protected]> * helper function for start time, handle date and datenanos Signed-off-by: Adam Tackett <[email protected]> * add toast messages for all errors service-traces, add mode to url Signed-off-by: Adam Tackett <[email protected]> * fix url re-direction in non custom state Signed-off-by: Adam Tackett <[email protected]> * address comments, add testing Signed-off-by: Adam Tackett <[email protected]> * update url #, send mode to applications Signed-off-by: Adam Tackett <[email protected]> * update helper function Signed-off-by: Adam Tackett <[email protected]> * add validation to url mode Signed-off-by: Adam Tackett <[email protected]> * fix applications removing traces redirect Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit a57c10e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
anirudha and
TackAdam
as code owners
TackAdam
approved these changes
Jan 8, 2025
paulstn
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a57c10e from #2298.