Skip to content

[Backport 2.x] Restore spans limit to 3000 in trace view #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Feb 19, 2025

  • restore spans max value to 3000 in trace view

Signed-off-by: Shenoy Pratik [email protected]

  • update filtering mechanism for span payloads

Signed-off-by: Shenoy Pratik [email protected]

  • avoid parsing again on re-render in trace view

Signed-off-by: Shenoy Pratik [email protected]


Signed-off-by: Shenoy Pratik [email protected]
(cherry picked from commit 84fbc2f)
PR to main : #2353

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* restore spans max value to 3000 in trace view

Signed-off-by: Shenoy Pratik <[email protected]>

* update filtering mechanism for span payloads

Signed-off-by: Shenoy Pratik <[email protected]>

* avoid parsing again on re-render in trace view

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 84fbc2f)
@ps48 ps48 changed the title [Backport 2.x] Update max spans 2x [Backport 2.x] Restore spans limit to 3000 in trace view Feb 19, 2025
@ps48 ps48 added bug Something isn't working traces traces telemetry related features labels Feb 19, 2025
@ps48 ps48 merged commit 55f9ee5 into opensearch-project:2.x Feb 19, 2025
12 of 22 checks passed
@ps48
Copy link
Member Author

ps48 commented Feb 19, 2025

CI is failing due to version mismatch OSD core 2.x points to 2.19.1 opensearch-project/OpenSearch-Dashboards#9410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working traces traces telemetry related features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants