-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom logs correlation #2375
Support custom logs correlation #2375
Conversation
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
- Coverage 56.53% 56.16% -0.37%
==========================================
Files 393 396 +3
Lines 15574 15852 +278
Branches 4284 4384 +100
==========================================
+ Hits 8804 8903 +99
- Misses 6705 6878 +173
- Partials 65 71 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Are we intentionally applying the log “Correlated log indicies” to links from “Data Prepper” or should it be isolated to only affecting Traces while under the “Custom Source” tab. It is currently applying to both which seems to be useful but just wanted to make sure that its intended. |
“View associated logs” redirection seems broken under the new navigation when “Explorer” is not present as it cannot land on the page. Don’t think this was introduced by this PR but restricts the ability to test the functionality with new home enabled. |
Did you have MDS enabled and query_enhancements enabled? -> We need this to make sure these are enabled, when explorer is missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, could we get tests?
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Note: We need to fixate of default timestamp in the next upcoming version. |
* support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 6ea90a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* support custom logs correlation * add support for custom field mappings in logs * update explorer fields * add support for custom timestamp field --------- (cherry picked from commit 6ea90a6) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
* Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to PR comments Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Support custom logs correlation (#2375) * support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to latest PR comments and suggestions made by Simeon Signed-off-by: Aaron Alvarez <aaarone@amazon.com> --------- Signed-off-by: Aaron Alvarez <aaarone@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Aaron Alvarez <aaarone@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
* Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Database selector in Integration install Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to PR comments Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * Support custom logs correlation (#2375) * support custom logs correlation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update explorer fields Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Aaron Alvarez <aaarone@amazon.com> * These changes are in response to latest PR comments and suggestions made by Simeon Signed-off-by: Aaron Alvarez <aaarone@amazon.com> --------- Signed-off-by: Aaron Alvarez <aaarone@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Aaron Alvarez <aaarone@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 588c8d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Many users of trace analytics have different ways of defining their logs index. Many of them do not want set an alias on their existing indices and fields. Hence, we are adding this experimental feature to enable them to add custom log source used for correlation of spans & services to logs.
Redirection to Explorer:
obs-correlated-logs.mov
Redirection to Discover:
NOTE: We see an error in discover to load data from specific indexes using PPL. This looks to be a discover only issue.
mds-correlated-logs.mov
Issues Resolved
#2141
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.