Service Content/View Optimizations #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
paulstn
reviewed
Mar 11, 2025
joshuali925
approved these changes
Mar 11, 2025
public/components/application_analytics/components/flyout_components/service_detail_flyout.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/services/services_content.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
paulstn
approved these changes
Mar 11, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Service Content/View Optimizations Signed-off-by: Adam Tackett <[email protected]> * remove console error, address comments on promise Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit f23c699) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Service Content/View Optimizations * remove console error, address comments on promise --------- (cherry picked from commit f23c699) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Service content and service view page called the following functions handleServicesRequest() and handleServiceViewRequest(). Both of these functions utilized handleServiceMapRequest() to determine connected services and metrics.
Services content and services view had an additional call directly to handleServiceMapRequest() for generating the service map displayed at the bottom of the page. By removing these calls and passing setServiceMap into handleServicesRequest() and handleServiceViewRequest() we are able to remove 2 unnecessary queries from both pages.
Before (Service Content: 5 queries, Service View: 7 queries)
Before.mov
After (Service Content: 3 queries, Service View: 5 queries)
After.mov
This change also reduces the calls made in application analytics
Before (Services: 5 queries, Flyout: 11 queries)
Before.mov
After (Services: 3 queries, Flyout: 7 queries)
After.mov
Issues Resolved
#2334 - Service Content/View Optimizations
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.