-
Notifications
You must be signed in to change notification settings - Fork 63
Traces - Custom source switch to data grid #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
…ate fix Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
joshuali925
reviewed
Mar 28, 2025
public/components/trace_analytics/components/common/helper_functions.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/common/helper_functions.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/common/helper_functions.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/traces/traces_content.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/common/helper_functions.tsx
Outdated
Show resolved
Hide resolved
public/components/trace_analytics/components/traces/trace_table_helpers.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Mar 31, 2025
...omponents/trace_analytics/components/common/shared_components/component_helper_functions.tsx
Show resolved
Hide resolved
ps48
reviewed
Mar 31, 2025
public/components/trace_analytics/components/common/shared_components/sharedComponents.scss
Outdated
Show resolved
Hide resolved
ps48
reviewed
Mar 31, 2025
public/components/trace_analytics/components/common/shared_components/custom_datagrid.tsx
Outdated
Show resolved
Hide resolved
ps48
reviewed
Mar 31, 2025
public/components/trace_analytics/components/traces/traces_custom_indices_table.tsx
Outdated
Show resolved
Hide resolved
joshuali925
approved these changes
Mar 31, 2025
Signed-off-by: Adam Tackett <[email protected]>
ps48
approved these changes
Apr 1, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
* change from memory table to eui data grid Signed-off-by: Adam Tackett <[email protected]> * progress on eui data grid and query Signed-off-by: Adam Tackett <[email protected]> * progress, seperated pagnation refresh, working on traces Signed-off-by: Adam Tackett <[email protected]> * rever traces to normal, handle both in UI Signed-off-by: Adam Tackett <[email protected]> * load more button for traces Signed-off-by: Adam Tackett <[email protected]> * refresh fixes, prevent requery of services with filter add, invalid date fix Signed-off-by: Adam Tackett <[email protected]> * remove test of removed state Signed-off-by: Adam Tackett <[email protected]> * inject html to format euidatagrid Signed-off-by: Adam Tackett <[email protected]> * add loader, fix pagination sorting, fix attribute columns Signed-off-by: Adam Tackett <[email protected]> * fix lint errors Signed-off-by: Adam Tackett <[email protected]> * add test back Signed-off-by: Adam Tackett <[email protected]> * add cypress testing Signed-off-by: Adam Tackett <[email protected]> * remove only Signed-off-by: Adam Tackett <[email protected]> * fix flaky service test Signed-off-by: Adam Tackett <[email protected]> * fix bug for pagnation in span list Signed-off-by: Adam Tackett <[email protected]> * address comments, fix full screen bug for pagination Signed-off-by: Adam Tackett <[email protected]> * address comments, fix sorting for traces Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit fd878ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a. Allowing pagination for the span pages (allowing all records to be investigated/filtered while greatly reducing the load time.)
b. Allowing adjusting of column size by user
1- Before (Memory Table -> Datagrid)

1- After (Memory Table -> Datagrid)

2- Before (Hide attributes -> Columns)

2- After (Hide attributes -> Columns)

3- Before (No loading -> "Load more data")

3- After (No loading -> "Load more data")

4- Before (Spans 500 results 500 hits-> Spans 10,000 results 335,227,683 hits)

4- After (Spans 500 results 500 hits-> Spans 10,000 results 335,227,683 hits)

Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.