Skip to content

Traces - Custom source switch to data grid #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 1, 2025

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Mar 14, 2025

Description

  1. Convert Custom source traces table from a memory table to a custom data grid.
    a. Allowing pagination for the span pages (allowing all records to be investigated/filtered while greatly reducing the load time.)
    b. Allowing adjusting of column size by user
  2. Remove "Hide Attributes" button, replace with attributes being searchable and hidden under columns.
  3. Change Custom source -> Traces to have "Load more" functionality to pull 500 more traces.
  4. Adjust Spans to be paginated and retrieve all "Hits" before applying things such as sorting.
  5. Fix a bug were pagination wasn't working correctly for "Span list"
  6. Fix a bug causing full screen to have incorrectly colored pagination bottom panel.

1- Before (Memory Table -> Datagrid)
Before1

1- After (Memory Table -> Datagrid)
After1

2- Before (Hide attributes -> Columns)
Before2

2- After (Hide attributes -> Columns)
After2

3- Before (No loading -> "Load more data")
Before3

3- After (No loading -> "Load more data")
After3

4- Before (Spans 500 results 500 hits-> Spans 10,000 results 335,227,683 hits)
Before4

4- After (Spans 500 results 500 hits-> Spans 10,000 results 335,227,683 hits)
After4

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TackAdam TackAdam added backport 2.x enhancement New feature or request labels Mar 20, 2025
Adam Tackett and others added 6 commits March 20, 2025 16:46
@TackAdam TackAdam marked this pull request as ready for review March 24, 2025 23:46
Adam Tackett added 3 commits March 24, 2025 16:47
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
@TackAdam
Copy link
Collaborator Author

Also added in a fix for the following bug causing full screen for traces in dark mode to not reflect the color on the bottom pagination.

          className={[
            isFullScreen ? 'full-wrapper' : 'normal-wrapper',
            isFullScreen && isDarkMode && 'dark-mode-enabled',
          ]
            .filter(Boolean)
            .join(' ')}

Before:

Before

After:

After

@ps48 ps48 merged commit fd878ee into opensearch-project:main Apr 1, 2025
18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 1, 2025
* change from memory table to eui data grid

Signed-off-by: Adam Tackett <[email protected]>

* progress on eui data grid and query

Signed-off-by: Adam Tackett <[email protected]>

* progress, seperated pagnation refresh, working on traces

Signed-off-by: Adam Tackett <[email protected]>

* rever traces to normal, handle both in UI

Signed-off-by: Adam Tackett <[email protected]>

* load more button for traces

Signed-off-by: Adam Tackett <[email protected]>

* refresh fixes, prevent requery of services with filter add, invalid date fix

Signed-off-by: Adam Tackett <[email protected]>

* remove test of removed state

Signed-off-by: Adam Tackett <[email protected]>

* inject html to format euidatagrid

Signed-off-by: Adam Tackett <[email protected]>

* add loader, fix pagination sorting, fix attribute columns

Signed-off-by: Adam Tackett <[email protected]>

* fix lint errors

Signed-off-by: Adam Tackett <[email protected]>

* add test back

Signed-off-by: Adam Tackett <[email protected]>

* add cypress testing

Signed-off-by: Adam Tackett <[email protected]>

* remove only

Signed-off-by: Adam Tackett <[email protected]>

* fix flaky service test

Signed-off-by: Adam Tackett <[email protected]>

* fix bug for pagnation in span list

Signed-off-by: Adam Tackett <[email protected]>

* address comments, fix full screen bug for pagination

Signed-off-by: Adam Tackett <[email protected]>

* address comments, fix sorting for traces

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit fd878ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants