fix: create report from context menu #636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tender-barbarian
requested review from
Swiddis,
TackAdam,
anirudha,
dai-chen,
joshuali925,
mengweieric,
penghuo,
ps48,
sumukhswamy and
vamsimanohar
as code owners
tender-barbarian
force-pushed
the
create-report-patch
branch
from
28d10ac to
6fb4e26
Compare
Signed-off-by: tender-barbarian <[email protected]>
tender-barbarian
force-pushed
the
create-report-patch
branch
from
6fb4e26 to
7f62f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
contextMenuCreateReportDefinition().There were two things wrong with it:
data-explorerin path test so it would yield empty result.location.assign()was appending path at the end of current path, resulting in<domain>/app/data-explorer/discover/reports-dashboards#/create?<params>which was of course wrong. Switched it tonavigateToApp().Issues Resolved
#576
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.