-
Notifications
You must be signed in to change notification settings - Fork 617
add OSB instructions to use session credentials #10681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Rishabh Singh <[email protected]>
Hey @rishabh6788, is this still under tech review or is it ready for the doc team review? |
@rishabh6788 Is this PR still applicable? |
Signed-off-by: Rishabh Singh <[email protected]>
--target-hosts=<CLUSTER ENDPOINT> \ | ||
--pipeline=benchmark-only \ | ||
--workload=geonames \ | ||
--client-options=timeout:120,amazon_aws_log_in:session,region:<region>,service:<service> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include the available options for service:
'aos', 'aoss'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. it is es
for managed service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rishabh6788!
_benchmark/user-guide/install-and-configure/configuring-benchmark.md
Outdated
Show resolved
Hide resolved
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add OSB instructions to use session credentials Signed-off-by: Rishabh Singh <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> * update service name param Signed-off-by: Rishabh Singh <[email protected]> --------- Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit e005909) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR updates the opensearch-benchmark installation and configuration page to include instructions on how to use session credentials for sigv4 authentication.
Issues Resolved
Closes #[Replace this text, including the brackets, with the issue number. Leave "Closes #" so the issue is closed properly.]
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.