Skip to content

Conversation

@Pigueiras
Copy link
Contributor

@Pigueiras Pigueiras commented Sep 19, 2025

Description

This PR updates plugins.security.kerberos.krb5_filepath to use a relative path and extends the existing clarification note about the keytab file, which is also required to be relative.

With Java 24 (bundled in OpenSearch 3.2), absolute paths no longer work due to stricter security restrictions introduced in newer JDK versions.

Issues Resolved

I can open one in this project if needed, but it's related to: opensearch-project/security#5646

Version

Only from 3.2 onwards.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

@cwperks Could you review this PR when you get a chance?

@kolchfa-aws
Copy link
Collaborator

@Pigueiras Could you please fix DCO in the meantime?

@kolchfa-aws kolchfa-aws added backport 3.2 Tech review PR: Tech review in progress labels Sep 19, 2025
@Pigueiras Pigueiras force-pushed the kerberos branch 2 times, most recently from 115595b to 61e890f Compare September 19, 2025 14:45
@cwperks
Copy link
Member

cwperks commented Sep 23, 2025

Thank you for the PR @Pigueiras. The changes lgtm and I do think its worthwhile to make this change on the documentation website.

With that being said, what you faced in the security repo is a bug that needs to be addressed there as well. Essentially the security repo needs to have a grant in its plugin-security.policy file like this: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/resources/org/opensearch/bootstrap/security.policy#L255

and the grant needs to reference the system prop that holds the location of the config file. Unfortunately, I don't know how to test kerberos setup in order to adequate prepare a bugfix.

@kolchfa-aws kolchfa-aws removed the Tech review PR: Tech review in progress label Sep 23, 2025
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Pigueiras! One rewording suggestion.

@kolchfa-aws kolchfa-aws added the Doc review PR: Doc review in progress label Sep 23, 2025
This commit updates `plugins.security.kerberos.krb5_filepath` to
use a relative path and extends the existing clarification note
about the `keytab` file, which is also required to be relative.

With Java 24 (bundled in OpenSearch 3.2), absolute paths no longer
work due to stricter security restrictions introduced in newer JDK
versions.

Related issue: [opensearch-project/security#5646](opensearch-project/security#5646)

Signed-off-by: Luis Pigueiras <[email protected]>
@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Doc review PR: Doc review in progress labels Sep 25, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Sep 25, 2025
@natebower natebower merged commit e733852 into opensearch-project:main Sep 25, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 25, 2025
…10985)

* Change `plugins.security.kerberos.krb5_filepath` to a relative path

This commit updates `plugins.security.kerberos.krb5_filepath` to
use a relative path and extends the existing clarification note
about the `keytab` file, which is also required to be relative.

With Java 24 (bundled in OpenSearch 3.2), absolute paths no longer
work due to stricter security restrictions introduced in newer JDK
versions.

Related issue: [opensearch-project/security#5646](opensearch-project/security#5646)

Signed-off-by: Luis Pigueiras <[email protected]>

* Update _security/authentication-backends/kerberos.md

Signed-off-by: Nathan Bower <[email protected]>

---------

Signed-off-by: Luis Pigueiras <[email protected]>
Signed-off-by: Nathan Bower <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit e733852)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants