Skip to content

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Sep 25, 2025

Description

Add documentation for unified OTLP source in Data prepper

Issues Resolved

Closes #11029

Version

Data prepper 2.12

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@ps48
Copy link
Member Author

ps48 commented Sep 25, 2025

Requested @dlvenable @shenkw1 for tech review

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ps48 for this contribution!

| Option | Type | Description |
| :--- | :--- | :--- |
| `ssl` | Boolean | Enables TLS/SSL. Default value is `true`. |
| `sslKeyCertChainFile` | String | Represents the SSL certificate chain file path or Amazon S3 path. For example, see the Amazon S3 path `s3://<bucketName>/<path>`. Required if `ssl` is set to `true`. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the readme is out of date, right now updated the docs PR a535376. Will update readme separately in Data Prepper repo.

| `logs_path` | String | The path for sending unframed HTTP requests for logs. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.logs.v1.LogsService/Export`. |
| `metrics_path` | String | The path for sending unframed HTTP requests for metrics. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.metrics.v1.MetricsService/Export`. |
| `traces_path` | String | The path for sending unframed HTTP requests for traces. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.trace.v1.TraceService/Export`. |
| `request_timeout` | Integer | The request timeout duration in milliseconds. Default value is `10000`. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Duration type, not an integer. The default value is 10s.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes updated it here: a535376

source:
otlp:
ssl: true
useAcmCertForSSL: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct to use underscores.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated:a535376

One of the key features of the OTLP source is the ability to route different telemetry signals (logs, metrics, traces) to different processors or sinks based on specific needs. The routing uses metadata-based routing with the `getEventType()` function.

```yaml
otel-telemetry-pipeline:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to recommend using this as our default configuration to share. It reduces some of the pipelines and works for sending traces, metrics, and logs to OpenSearch.

https://github.com/dlvenable/data-prepper-samples/blob/a8e7b4350e0ac88b829869131ac736dbff6d3910/samples/otlp-pipeline/data-prepper/pipelines/pipeline.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes this is way simper, updated: a535376

source:
otlp:
ssl: true
sslKeyCertChainFile: "/path/to/certificate.crt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct to use underscores.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated: a535376

Signed-off-by: ps48 <[email protected]>
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ps48 !

@kolchfa-aws kolchfa-aws added Doc review PR: Doc review in progress backport 3.2 labels Sep 26, 2025
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws
Copy link
Collaborator

Thank you, @ps48! Doc review complete. It would be very helpful to provide an example in the migration section. Could you add one that has existing configuration using logs, metrics, and traces in different sources and a new configuration using the otlp source?

@ps48
Copy link
Member Author

ps48 commented Sep 30, 2025

Hi @kolchfa-aws, I've the migration section with an example e3b777e

@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Doc review PR: Doc review in progress labels Oct 1, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Oct 1, 2025
@natebower natebower merged commit e493b73 into opensearch-project:main Oct 1, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2025
* add documentation for unified OTLP source

Signed-off-by: ps48 <[email protected]>

* update getEventType function documentation

Signed-off-by: ps48 <[email protected]>

* Adding style updates

Signed-off-by: ps48 <[email protected]>

* update when condition

Signed-off-by: ps48 <[email protected]>

* resolve comments

Signed-off-by: ps48 <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* update migration section with example

Signed-off-by: ps48 <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

* Update _data-prepper/pipelines/configuration/sources/otlp-source.md

Signed-off-by: kolchfa-aws <[email protected]>

* Update _data-prepper/pipelines/configuration/sources/otlp-source.md

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Signed-off-by: Nathan Bower <[email protected]>

---------

Signed-off-by: ps48 <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Nathan Bower <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit e493b73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] OpenSearch Data prepper unified otlp source

5 participants