-
Notifications
You must be signed in to change notification settings - Fork 616
Add documentation for unified OTLP source in Data prepper #11033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ps48 <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Requested @dlvenable @shenkw1 for tech review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ps48 for this contribution!
| Option | Type | Description | | ||
| :--- | :--- | :--- | | ||
| `ssl` | Boolean | Enables TLS/SSL. Default value is `true`. | | ||
| `sslKeyCertChainFile` | String | Represents the SSL certificate chain file path or Amazon S3 path. For example, see the Amazon S3 path `s3://<bucketName>/<path>`. Required if `ssl` is set to `true`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using underscore for spaces in this plugin.
Please update the configuration names accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the readme is out of date, right now updated the docs PR a535376. Will update readme separately in Data Prepper repo.
| `logs_path` | String | The path for sending unframed HTTP requests for logs. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.logs.v1.LogsService/Export`. | | ||
| `metrics_path` | String | The path for sending unframed HTTP requests for metrics. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.metrics.v1.MetricsService/Export`. | | ||
| `traces_path` | String | The path for sending unframed HTTP requests for traces. Must start with `/` and have a minimum length of 1. Default value is `/opentelemetry.proto.collector.trace.v1.TraceService/Export`. | | ||
| `request_timeout` | Integer | The request timeout duration in milliseconds. Default value is `10000`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Duration
type, not an integer. The default value is 10s
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes updated it here: a535376
source: | ||
otlp: | ||
ssl: true | ||
useAcmCertForSSL: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct to use underscores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated:a535376
One of the key features of the OTLP source is the ability to route different telemetry signals (logs, metrics, traces) to different processors or sinks based on specific needs. The routing uses metadata-based routing with the `getEventType()` function. | ||
|
||
```yaml | ||
otel-telemetry-pipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to recommend using this as our default configuration to share. It reduces some of the pipelines and works for sending traces, metrics, and logs to OpenSearch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes this is way simper, updated: a535376
source: | ||
otlp: | ||
ssl: true | ||
sslKeyCertChainFile: "/path/to/certificate.crt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct to use underscores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated: a535376
Signed-off-by: ps48 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ps48 !
Signed-off-by: Fanit Kolchina <[email protected]>
Thank you, @ps48! Doc review complete. It would be very helpful to provide an example in the migration section. Could you add one that has existing configuration using logs, metrics, and traces in different sources and a new configuration using the otlp source? |
Signed-off-by: ps48 <[email protected]>
Hi @kolchfa-aws, I've the migration section with an example e3b777e |
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review
Signed-off-by: Nathan Bower <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add documentation for unified OTLP source Signed-off-by: ps48 <[email protected]> * update getEventType function documentation Signed-off-by: ps48 <[email protected]> * Adding style updates Signed-off-by: ps48 <[email protected]> * update when condition Signed-off-by: ps48 <[email protected]> * resolve comments Signed-off-by: ps48 <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * update migration section with example Signed-off-by: ps48 <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> * Update _data-prepper/pipelines/configuration/sources/otlp-source.md Signed-off-by: kolchfa-aws <[email protected]> * Update _data-prepper/pipelines/configuration/sources/otlp-source.md Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Signed-off-by: Nathan Bower <[email protected]> --------- Signed-off-by: ps48 <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit e493b73) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add documentation for unified OTLP source in Data prepper
Issues Resolved
Closes #11029
Version
Data prepper 2.12
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.