-
Notifications
You must be signed in to change notification settings - Fork 618
[Pull-based Ingestion] Add all-active ingestion mode documentation #11122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Add all-active ingestion mode documentation #11122
Conversation
Signed-off-by: Varun Bharadwaj <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @varunbharadwaj! I provided suggestions based on my assumption that the ingestion mode depends entirely on the index’s replication type (segment vs. document replication). If that’s the case, what does the all_active
parameter do? If an index is in segment replication, then you can't set all_active
but if it's in document replication, what's the difference between all_active
true and false?
Thanks for the quick review @kolchfa-aws . The all-active mode is only supported when the replication type is DOCUMENT (the default replication type today). We do not want to support this mode in segment replication mode. However, the all-active mode does not really do any replication at all, and therefore a different concept from replication type. In all-active mode, the replicas also process the indexing updates similar to document replication mode, and hence i was thinking it can be portrayed as a doc-rep equivalent in pull-based ingestion. |
If all_active = true, then replication type must be document. If all_active = false, replication type must be segment. |
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Varun Bharadwaj <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Varun Bharadwaj <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Updated the ingestion mode descriptions and added an image for each mode for clarity. |
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Nathan Bower <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add documentation for all-active ingestion mode and related APIs in pull-based ingestion. This mode has been introduced as a document replication equivalent with additional fields added in the GetIngestionState API.
Issues Resolved
Closes #11121
Version
3.3 onwards
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.