Skip to content

Conversation

ruai0511
Copy link
Contributor

@ruai0511 ruai0511 commented Oct 1, 2025

Description

Currently Rule-based Auto-tagging documentation page only contains documentation for index_pattern attribute. We're adding new principal attributes in OS 3.3, so this PR update the documentation to reflect this.

Issues Resolved

Closes #11134

Version

3.3+

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Oct 1, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@ruai0511 ruai0511 marked this pull request as draft October 1, 2025 20:17
@kolchfa-aws kolchfa-aws added In progress Issue/PR: The issue or PR is in progress. release-notes PR: Include this PR in the automated release notes v3.3.0 labels Oct 1, 2025
@ruai0511 ruai0511 marked this pull request as ready for review October 8, 2025 18:20
Copy link
Contributor

@kaushalmahi12 kaushalmahi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one minor comment.


| Attribute | Data type | Description | Priority |
|:---------------------|:----------|:------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|:---------|
| `principal.username` | List | A list of strings used to specify the usernames that should be matched to this rule. This attribute can only be used when the domain enables security plugin and only support exact matching. | 1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving the priority might be confusing since user never sets it rather it is implicit, hence I think rephrasing it with something like following table defines the priority order of the attributes in decreasing order. The priority here is implicit and can't be modified by the user

@kolchfa-aws kolchfa-aws added Tech review PR: Tech review in progress and removed In progress Issue/PR: The issue or PR is in progress. labels Oct 8, 2025
@kaushalmahi12
Copy link
Contributor

Lets also add couple of examples around tie breaking mechanism in the autotagging guide

@kolchfa-aws kolchfa-aws added Doc review PR: Doc review in progress and removed Tech review PR: Tech review in progress labels Oct 9, 2025
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress and removed Doc review PR: Doc review in progress labels Oct 9, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natebower natebower removed the Editorial review PR: Editorial review in progress label Oct 9, 2025
@natebower natebower merged commit 36450ef into opensearch-project:main Oct 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes PR: Include this PR in the automated release notes v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Update Rule-based Auto-tagging documentation to include principal attributes

4 participants