Skip to content

Conversation

AntonEliatra
Copy link
Contributor

Description

Add length token filter docs

Issues Resolved

Closes #8152

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Sep 2, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Sep 3, 2024
@vagimeli vagimeli added Tech review PR: Tech review in progress Needs SME labels Sep 3, 2024
@vagimeli
Copy link
Contributor

vagimeli commented Sep 3, 2024

@udabhas Will you review this PR for technical accuracy? Thank you.

Signed-off-by: AntonEliatra <[email protected]>
@vagimeli
Copy link
Contributor

vagimeli commented Oct 3, 2024

@udabhas Will you review this PR for technical accuracy? Thank you.

@udabhas @varun-lodaya This is a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.

AntonEliatra and others added 2 commits October 16, 2024 18:47
Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws added Editorial review PR: Editorial review in progress backport 2.18 PR: Backport label for 2.18 and removed Tech review PR: Tech review in progress Needs SME labels Nov 15, 2024
@kolchfa-aws kolchfa-aws assigned kolchfa-aws and unassigned vagimeli Nov 15, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws One comment and a few changes. Thanks!


# Length token filter

The `length` token filter is used to remove tokens that don't meet specified length criteria, such as minimum and maximum values, from the token stream.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written, this implies that there are sometimes other length criteria considered. Are there, or does this filter only consider the min and max values?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only min and max - reworded.

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
@kolchfa-aws kolchfa-aws merged commit 2d1d817 into opensearch-project:main Dec 2, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 2, 2024
* Add length token filter docs #8152

Signed-off-by: Anton Rubin <[email protected]>

* Update length.md

Signed-off-by: AntonEliatra <[email protected]>

* updating parameter table

Signed-off-by: Anton Rubin <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 2d1d817)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AntonEliatra AntonEliatra deleted the adding-length-token-filter-docs branch December 2, 2024 13:56
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
epugh pushed a commit to o19s/documentation-website that referenced this pull request Jul 2, 2025
…ect#8156)

* Add length token filter docs opensearch-project#8152

Signed-off-by: Anton Rubin <[email protected]>

* Update length.md

Signed-off-by: AntonEliatra <[email protected]>

* updating parameter table

Signed-off-by: Anton Rubin <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.18 PR: Backport label for 2.18 Content gap Editorial review PR: Editorial review in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token filters - length [DOC]

4 participants