Add documentation for Faiss byte vector #8170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws,
natebower,
stephen-crawford and
vagimeli
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
added
Tech review
|
Can we just club byte vector for both lucene and faiss as single content? From customer's perspective, there is no difference between the two. |
heemin32
reviewed
Sep 11, 2024
Signed-off-by: Naveen Tatikonda <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
naveentatikonda
force-pushed
the
add_faiss_byte_vector_doc
branch
from
2378ea2 to
3a6a013
Compare
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
add_faiss_byte_vector_doc
branch
from
3a6a013 to
ddbfa42
Compare
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
reviewed
Sep 13, 2024
There was a problem hiding this comment.
@naveentatikonda @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
reviewed
Sep 13, 2024
kolchfa-aws
reviewed
Sep 13, 2024
kolchfa-aws
reviewed
Sep 13, 2024
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
noahstaveley
pushed a commit
to noahstaveley/documentation-website
that referenced
this pull request
Sep 23, 2024
* Add documentation for Faiss byte vector Signed-off-by: Naveen Tatikonda <[email protected]> * A couple of rewordings and format changes before tech review Signed-off-by: Fanit Kolchina <[email protected]> * Address Review Comments Signed-off-by: Naveen Tatikonda <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> * Add clarification to memory estimation formulas Signed-off-by: Fanit Kolchina <[email protected]> * Typo fix Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Naveen Tatikonda <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Noah Staveley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for Faiss byte vector
Issues Resolved
Closes #7661
Version
2.17
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.